fix: Recognize Evaluation-Kinetics sheet and SCK analyte lookup#1204
Merged
nathan-stender merged 2 commits intoMay 21, 2026
Conversation
…alyte The parser failed to find kinetics data (ka, kd, KD, Rmax) when the sheet was named "Evaluation-Kinetics" (no spaces around dash) instead of "Evaluation - Kinetics". Also, for Single Cycle Kinetics experiments the analyte identity is in "Single cycle kinetics 1 Solution" rather than "Analyte 1 Solution", causing key mismatches in the kinetics lookup. Added _find_sheet() and _find_sheets_with_prefix() helpers that normalize dash/space separators before comparing, fixing all sheet name lookups (QC sheets, Evaluation-Kinetics, Evaluation-Trend/Preced). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nathan-stender
force-pushed
the
fix/biacore-kinetics-sheet-name-and-sck-lookup
branch
from
May 21, 2026 14:28
643b57a to
dc21cd7
Compare
Adds "Single cycle kinetics 1 Solution" column to the report point table test data so kinetics lookup keys match, verifying that ka, kd, KD, and Rmax appear in the output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nathan-stender
requested review from
tamargrey
and removed request for
stephenworlow
May 21, 2026 16:03
tamargrey
approved these changes
May 21, 2026
nathan-stender
added a commit
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Evaluation - Kinetics"and"Evaluation-Kinetics"sheet names when loading kinetics data (some exports omit spaces around the dash)"Single cycle kinetics 1 Solution"over"Analyte 1 Solution"when building the kinetics lookup key — otherwise ka, kd, KD, and Rmax are silently dropped because the keys never matchTest plan
🤖 Generated with Claude Code