fix: Map missing fields in Chromeleon parser for adapter migration#1207
Merged
Conversation
The Chromeleon adapter is migrating from producing ASM directly to producing raw JSON that goes through the allotropy parser. This fixes all field mapping gaps so the parser output matches the old adapter. - Handle null device_information without crashing - Map analyst (injection.last update user name) per LC document - Map submitter (injection.creation user name) per LC document - Map injection name to sample document written name - Use signal name as device type instead of hardcoded "HPLC" - Use sampler model number as asset management identifier when available - Merge non-null custom variables into injection custom info Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephenworlow
approved these changes
May 26, 2026
nathan-stender
added a commit
that referenced
this pull request
May 26, 2026
### Fixed - Map missing fields in Chromeleon parser for adapter migration (#1207)
4 tasks
nathan-stender
added a commit
that referenced
this pull request
May 27, 2026
…ser (#1210) ## Summary - Maps `relative area group` from peak data into peak custom information document - Maps `number of calibration points` from peak data into peak custom information document ## Context Follow-up to #1207. These two peak-level fields were identified as unmapped gaps between the old Chromeleon adapter output and the new allotropy parser output. The gap report also flagged `bandwidth setting` and `relative retention time` but those are already correctly mapped (bandwidth as `detector bandwidth setting`, relative retention time as a standard peak field). ## Test plan - [x] Verified `relative area group` appears in output (e.g. 6.65 in Glycans peaks) - [x] Verified `number of calibration points` appears in output (0.0 in BioChem/S15 peaks) - [x] All Chromeleon parser tests pass - [x] Regenerated `new_updated/` output files for downstream CSV parser comparison 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
device_informationisnullin raw JSON (Glycans sequence)analystandsubmitterper LC document from injection-level fieldsinjection name→sample document.written namesignal nameasdevice typeinstead of hardcoded "HPLC"sampler model numberasasset management identifierwhen availableContext
The Chromeleon adapter is migrating from producing ASM directly to producing a raw JSON dump parsed by the allotropy
BENCHLING_CHROMELEONparser. The raw JSON contains all the data but several critical fields were not being mapped into ASM output. This PR closes all mapping gaps so the new pipeline produces equivalent output to the old adapter.Test plan
🤖 Generated with Claude Code