docs: Add Supported Detection Modes column to instrument table#1209
Merged
Conversation
Adds a fifth column to the supported instruments table showing what detection modes each parser supports. Values derived from parser code (constants, MeasurementType enums, schema mapper usage). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
james-leinas
approved these changes
May 27, 2026
3 tasks
nathan-stender
added a commit
that referenced
this pull request
Jun 2, 2026
…le (#1219) ## Summary - PR #1209 manually added a "Supported Detection Modes" column to the instruments table, but the table is auto-generated by `hatch run scripts:update-instrument-table` - This PR moves detection mode data into parser class attributes (`SUPPORTED_DETECTION_MODES`) so the generation script produces the column automatically - Adds `SUPPORTED_DETECTION_MODES: str | None = None` to the `VendorParser` base class - Declares detection modes in all 53 parser classes (matching the values from PR #1209) - Updates `get_table_contents()` to render the 5th column ## Changes - `vendor_parser.py`: New optional class attribute - `parser_factory.py`: New `supported_detection_modes` property on `Vendor`, updated table generation - All 53 parser files: One-line addition of `SUPPORTED_DETECTION_MODES = "..."` (or `None` for liquid handlers) ## Test plan - [x] `test_table_contents` passes — generated output matches the existing `.adoc` file - [x] All 318 parser_factory and discover_vendor tests pass - [x] Lint passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPPORTED_INSTRUMENT_SOFTWARE.adocDetection modes by category
Test plan
🤖 Generated with Claude Code