fix: Map relative area group and calibration points in Chromeleon parser#1210
Merged
Merged
Conversation
…meleon parser These peak-level fields from the raw Chromeleon JSON were not being mapped to the ASM output. They are now included in the peak custom information document. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nathan-stender
force-pushed
the
fix/chromeleon-map-peak-custom-fields
branch
from
May 26, 2026 23:16
72f1112 to
237edba
Compare
ajcariaga16
approved these changes
May 26, 2026
nathan-stender
added a commit
that referenced
this pull request
May 27, 2026
### Fixed - Map relative area group and calibration points in Chromeleon parser (#1210)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
relative area groupfrom peak data into peak custom information documentnumber of calibration pointsfrom peak data into peak custom information documentContext
Follow-up to #1207. These two peak-level fields were identified as unmapped gaps between the old Chromeleon adapter output and the new allotropy parser output.
The gap report also flagged
bandwidth settingandrelative retention timebut those are already correctly mapped (bandwidth asdetector bandwidth setting, relative retention time as a standard peak field).Test plan
relative area groupappears in output (e.g. 6.65 in Glycans peaks)number of calibration pointsappears in output (0.0 in BioChem/S15 peaks)new_updated/output files for downstream CSV parser comparison🤖 Generated with Claude Code