fix: Correct peak height and area unit conversions in Chromeleon parser#1212
Merged
Merged
Conversation
Peak height is already in mAU from Chromeleon — remove erroneous /1000. Peak area is in mAU·min from Chromeleon — convert to mAU·s by multiplying by 60 instead of dividing by 1000. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajcariaga16
approved these changes
May 27, 2026
nathan-stender
added a commit
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/1000division/1000with×60to convert to mAU·s (the ASM unit)Both bugs were confirmed by comparing raw vendor JSON against old adapter ASM output across 8 production sequences (1121 peaks). The old adapter passed height through unchanged and the
/1000was producing values 1000x too small.Test plan
🤖 Generated with Claude Code