feat: Add SUPPORTED_DETECTION_MODES to parsers for auto-generated table#1219
Merged
Conversation
The supported instruments table was previously manually updated with detection modes (PR #1209). This moves the data into parser class attributes so the table generation script produces the column automatically. - Add SUPPORTED_DETECTION_MODES attribute to VendorParser base class - Declare detection modes in all 53 parser classes - Update get_table_contents() to include the 5th column Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…N_MODES - Add $SUPPORTED_DETECTION_MODES$ placeholder to parser_template - Add --detection_modes CLI option to create_parser.py script - Update parser-generator skill docs with detection modes guidance - Update skill's create_parser.py to include the attribute with TODO - Add "update-instrument-table" to next steps in both docs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephenworlow
approved these changes
Jun 2, 2026
nathan-stender
added a commit
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hatch run scripts:update-instrument-tableSUPPORTED_DETECTION_MODES) so the generation script produces the column automaticallySUPPORTED_DETECTION_MODES: str | None = Noneto theVendorParserbase classget_table_contents()to render the 5th columnChanges
vendor_parser.py: New optional class attributeparser_factory.py: Newsupported_detection_modesproperty onVendor, updated table generationSUPPORTED_DETECTION_MODES = "..."(orNonefor liquid handlers)Test plan
test_table_contentspasses — generated output matches the existing.adocfile🤖 Generated with Claude Code