fix: Make space optional in Cytiva UNICORN UV curve regexes#1229
Merged
Conversation
Some UNICORN exports (e.g. AKTApilot) declare UV curves without a space between "UV" and the number (UV1_280, UV2_0, UV3_0) while others use a space (UV 1_280). The regexes now accept both formats, preventing silent loss of absorbance measurements. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephenworlow
approved these changes
Jun 11, 2026
nathan-stender
added a commit
that referenced
this pull request
Jun 11, 2026
### Fixed - Make space optional in Cytiva UNICORN UV curve regexes (#1229)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UV 1_,UV 2_,UV 3_→UV ?1_,UV ?2_,UV ?3_)Context
Some UNICORN exports declare UV curves as
UV1_280/UV2_0/UV3_0(no space), while others useUV 1_280(with space). The previous regexes required the space, causingfilter_curve_or_none()to returnNoneand silently skip all absorbance measurements.Reproduced on an AKTApilot 02 export (batch BRR-92117):
Test plan
🤖 Generated with Claude Code