Skip to content

fix: Accept numeric-only Machine ID in Mabtech APEX parser#1231

Merged
nathan-stender merged 2 commits into
mainfrom
fix/mabtech-apex-numeric-machine-id
Jun 17, 2026
Merged

fix: Accept numeric-only Machine ID in Mabtech APEX parser#1231
nathan-stender merged 2 commits into
mainfrom
fix/mabtech-apex-numeric-machine-id

Conversation

@nathan-stender

Copy link
Copy Markdown
Collaborator

Summary

  • Some APEX instruments export only a numeric serial number (e.g. "554") in the Machine ID field instead of the expected "Model Number" format (e.g. "IRIS 1234")
  • The strict regex caused an AllotropeConversionError: Unable to interpret Machine ID failure
  • Now handles bare numeric IDs by using the number as the serial and setting model to N/A

Test plan

  • Verified both failing files (Copy_of_XX039002_2.xlsx, XX067088.xlsx) now parse successfully
  • Existing mabtech_apex tests still pass (4/4)

🤖 Generated with Claude Code

Some APEX instruments export only a numeric serial number (e.g. "554")
in the Machine ID field instead of the expected "Model Number" format
(e.g. "IRIS 1234"). This caused parsing to fail with
"Unable to interpret Machine ID".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nathan-stender
nathan-stender requested review from a team and slopez-b as code owners June 16, 2026 17:04
stephenworlow
stephenworlow previously approved these changes Jun 16, 2026
@nathan-stender
nathan-stender merged commit 919fbbb into main Jun 17, 2026
9 checks passed
@nathan-stender
nathan-stender deleted the fix/mabtech-apex-numeric-machine-id branch June 17, 2026 15:15
nathan-stender added a commit that referenced this pull request Jun 19, 2026
### Added

- Add HIAC .xls file support to Beckman PharmSpec parser (#1232)

### Fixed

- Accept numeric-only Machine ID in Mabtech APEX parser (#1231)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants