Skip to content

fix: Accept numeric-only Machine ID in Mabtech APEX parser #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathan-stender merged 2 commits into from
Jun 17, 2026
Merged

fix: Accept numeric-only Machine ID in Mabtech APEX parser #1231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f24806f
fix: Accept numeric-only Machine ID in Mabtech APEX parser
nathan-stender Jun 16, 2026
1c7fdb8
Fix lint
nathan-stender Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/allotropy/parsers/mabtech_apex/mabtech_apex_structure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,29 +13,33 @@
Metadata,
ProcessedData,
)
from allotropy.exceptions import AllotropeParsingError
from allotropy.exceptions import AllotropeConversionError, AllotropeParsingError
from allotropy.parsers.constants import NOT_APPLICABLE
from allotropy.parsers.mabtech_apex import constants
from allotropy.parsers.utils.pandas import SeriesData
from allotropy.parsers.utils.uuids import random_uuid_str
from allotropy.parsers.utils.values import assert_not_none


def create_metadata(plate_info: SeriesData, file_path: str) -> Metadata:
machine_id = assert_not_none(
re.match(
"([A-Z]+[a-z]*) ([0-9]+)",
plate_info[str, "Machine ID"],
),
msg="Unable to interpret Machine ID",
)
raw_machine_id = plate_info[str, "Machine ID"]
machine_id_match = re.match(r"([A-Z]+[a-z]*) ([0-9]+)", raw_machine_id)

if machine_id_match:
model_number = machine_id_match.group(1)
serial_number = machine_id_match.group(2)
elif re.fullmatch(r"[0-9]+", raw_machine_id):
model_number = NOT_APPLICABLE
serial_number = raw_machine_id
else:
msg = f"Unable to interpret Machine ID: {raw_machine_id}"
raise AllotropeConversionError(msg)

return Metadata(
device_identifier=NOT_APPLICABLE,
software_name=constants.SOFTWARE_NAME,
software_version=plate_info.get(str, "Software Version"),
model_number=machine_id.group(1),
equipment_serial_number=machine_id.group(2),
model_number=model_number,
equipment_serial_number=serial_number,
file_name=Path(file_path).name,
unc_path=plate_info.get(str, "Path", file_path),
custom_info=plate_info.get_unread(),
Expand Down
Loading