feat: Add HIAC .xls file support to Beckman PharmSpec parser#1232
Merged
Conversation
The HIAC 9703+ instrument outputs .xls files in two sub-formats (binary OLE2 and HTML masquerading as .xls) with a "Run Counter Test" layout. This extends the existing PharmSpec parser to handle both formats since the data structure (particle size distributions) is identical. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephenworlow
previously approved these changes
Jun 17, 2026
- Fix CalculatedDataConfigWithOptional import path in calcdocs/api.py - Use project read_excel wrapper instead of pd.read_excel in PharmSpec parser/reader - Fix pd.read_html call to pass decoded string instead of BytesIO Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephenworlow
approved these changes
Jun 17, 2026
nathan-stender
added a commit
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.xlsfiles (both binary OLE2 and HTML-masquerading-as-XLS formats)Sample NamevsProbe,View Volume (%)vsView Volume)Test plan
.xlstest files parse correctly (binary and HTML formats).xlsparsers)🤖 Generated with Claude Code