fix: Surface previously skipped columns as custom info in NovaBio Flex2 parser#1236
Merged
Merged
Conversation
…x2 parser Sample Time, PCO2 @ Temp, PO2 @ Temp, and pH @ Temp were incorrectly marked as unused_keys and dropped from output. These fields are not duplicates of already-mapped ASM fields and should flow through to custom_info. Operator and Osm remain in unused_keys since they are consumed elsewhere (analyst and osmolality respectively). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephenworlow
approved these changes
Jun 29, 2026
nathan-stender
added a commit
that referenced
this pull request
Jun 29, 2026
### Fixed - Surface previously skipped columns as custom info in NovaBio Flex2 parser (#1236)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sample Time,PCO2 @ Temp,PO2 @ Temp, andpH @ Tempwere incorrectly marked asunused_keysin the NovaBio Flex2 parser (introduced in feat: NovaBio Flex2 - use SeriesData.get_unread #1070)unused_keysso they now flow through tocustom_infoin the outputOperatorandOsmremain suppressed since they are consumed elsewhere (asanalystandosmolalityrespectively)Test plan
🤖 Generated with Claude Code