fix: Support HIAC Run Counter format in .xlsx files for Beckman PharmSpec parser#1238
Merged
Merged
Conversation
…Spec parser The xlsx reader assumed all .xlsx files use the PharmSpec format (with an Approver_ marker), but HIAC instruments can also export the Run Counter Test format as .xlsx. Detect the format by checking whether column 1 contains bare ":" cells (PharmSpec 3-column layout) vs ": value" strings (HIAC Run Counter 2-column layout), and route to the existing _parse_hiac_run_counter_format handler accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajcariaga16
approved these changes
Jun 30, 2026
nathan-stender
added a commit
that referenced
this pull request
Jul 1, 2026
### Fixed - Support HIAC Run Counter format in .xlsx files for Beckman PharmSpec parser (#1238)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.xlsx, not just.xls_read_xlsxmethod assumed all.xlsxfiles use the PharmSpec format (which has anApprover_footer marker), causingAllotropeConversionErroron HIAC Run Counter.xlsxfileskey|:|value), while HIAC Run Counter uses a 2-column layout (key|: value). Routes to the existing_parse_hiac_run_counter_formathandler when the file isn't PharmSpec.Test plan
missing_approvererror test).xlsxHIAC file now parses successfully.xlsHIAC files still parse correctly🤖 Generated with Claude Code