Skip to content

fix: Support HIAC Run Counter format in .xlsx files for Beckman PharmSpec parser #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathan-stender merged 1 commit into from
Jun 30, 2026
Merged

fix: Support HIAC Run Counter format in .xlsx files for Beckman PharmSpec parser #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/allotropy/parsers/beckman_pharmspec/beckman_pharmspec_reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ def __init__(self, named_file_contents: NamedFileContents) -> None:
def _read_xlsx(self, named_file_contents: NamedFileContents) -> None:
df = read_excel(named_file_contents.contents, header=None, engine="calamine")

# Detect format: PharmSpec uses col1=":" with value in col2,
# HIAC Run Counter uses col1=": value" (colon+value merged).
is_pharmspec = df[1].str.strip().eq(":").any() if 1 in df.columns else False
if not is_pharmspec:
self._parse_hiac_run_counter_format(df)
return

"""
Find the data in the raw dataframe. We identify the boundary of the data
by finding the index first row which contains the word 'Particle' and ending right before
Expand Down
Loading