fix: Support SpectraMax 340PC-384 kinetic files in SoftMax Pro parser#1240
Merged
Conversation
Multiple issues prevented parsing of SpectraMax 340PC-384 kinetic export files: 1. Encoding: use chardet detection instead of assuming UTF-8, since these files are typically ISO-8859-1 encoded 2. Empty groups: handle Group blocks with no data rows (e.g. empty Standards groups) gracefully instead of erroring 3. Partial plates: skip wells with no data in kinetic mode rather than erroring; wells populated at t=0 that go missing later still error 4. Time format: accept M:SS and H:MM in addition to HH:MM:SS 5. GroupColumns: make Formula Name/Formula section optional since some export formats don't include it Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sanitized test file exercising all the newly supported format features: Latin-1 encoding, M:SS time format, empty group blocks with no data, no GroupColumns section, and partial plate with unused wells. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajcariaga16
reviewed
Jul 13, 2026
ajcariaga16
previously approved these changes
Jul 13, 2026
The 2-part format is M:SS (minutes:seconds), not H:MM, since there's no way to disambiguate and the file's 30-second interval confirms it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
stephenworlow
approved these changes
Jul 14, 2026
nathan-stender
added a commit
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time_to_secondsnow acceptsM:SSandH:MMin addition to strictHH:MM:SSGroup Column/Formula Namesections no longer errorTest plan
46_SpectraMax340PC-384.txt) parses successfully🤖 Generated with Claude Code