Skip to content

Commit 3b7b716

Browse files
committed
Update examples and fix tests
1 parent 1d0c4f2 commit 3b7b716

File tree

5 files changed

+9
-25
lines changed

5 files changed

+9
-25
lines changed

examples/simple-android/AndroidManifest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
3-
package="com.rules.android.lint.examples">
3+
package="com.rules.android.lint">
44

5-
<uses-permission android:name="android.permission.QUERY_ALL_PACKAGES" />
6-
7-
<uses-sdk android:minSdkVersion="23"/>
5+
<uses-sdk android:minSdkVersion="23" />
86

97
<application>
108
<activity

examples/simple-android/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ android_library(
1212
android_binary(
1313
name = "bin",
1414
srcs = ["Foo.java"],
15-
custom_package = "com.rules.android.lint.examples",
15+
custom_package = "com.rules.android.lint",
1616
manifest = "AndroidManifest.xml",
1717
deps = [
1818
":lib",

examples/simple-android/TestActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.rules.android.lint.examples;
1+
package com.rules.android.lint;
22

33
import android.app.Activity;
44

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,9 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<issues format="6" by="lint 8.3.0-alpha09">
2+
<issues format="6" by="lint 8.3.0-alpha09" type="baseline" client="" dependencies="false" name="" variant="all" version="8.3.0-alpha09">
33

44
<issue
55
id="DefaultLocale"
6-
severity="Error"
76
message="Implicitly using the default locale is a common source of bugs: Use `toUpperCase(Locale)` instead. For strings meant to be internal use `Locale.ROOT`, otherwise `Locale.getDefault()`."
8-
category="Correctness"
9-
priority="6"
10-
summary="Implied default locale in case conversion"
11-
explanation="Calling `String#toLowerCase()` or `#toUpperCase()` **without specifying an explicit locale** is a common source of bugs. The reason for that is that those methods will use the current locale on the user&apos;s device, and even though the code appears to work correctly when you are developing the app, it will fail in some locales. For example, in the Turkish locale, the uppercase replacement for `i` is **not** `I`.&#xA;&#xA;If you want the methods to just perform ASCII replacement, for example to convert an enum name, call `String#toUpperCase(Locale.US)` instead. If you really want to use the current locale, call `String#toUpperCase(Locale.getDefault())` instead."
12-
url="https://developer.android.com/reference/java/util/Locale.html#default_locale"
13-
urls="https://developer.android.com/reference/java/util/Locale.html#default_locale"
147
errorLine1=" System.out.println(&quot;WRONG&quot;.toUpperCase());"
158
errorLine2=" ~~~~~~~~~~~">
169
<location
@@ -19,4 +12,4 @@
1912
column="32"/>
2013
</issue>
2114

22-
</issues>
15+
</issues>s
Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,15 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<issues format="6" by="lint 8.3.0-alpha09">
2+
<issues format="6" by="lint 8.3.0-alpha09" type="baseline" client="" dependencies="false" name="" variant="all" version="8.3.0-alpha09">
33

44
<issue
55
id="ExpiredTargetSdkVersion"
6-
severity="Fatal"
76
message="Google Play requires that apps target API level 33 or higher."
8-
category="Compliance"
9-
priority="8"
10-
summary="TargetSdkVersion No Longer Supported"
11-
explanation="Configuring your app to target a recent API level ensures that users benefit from significant security and performance improvements, while still allowing your app to run on older Android versions (down to the `minSdkVersion`).&#xA;&#xA;To update your `targetSdkVersion`, follow the steps from &quot;Meeting Google Play requirements for target API level&quot;, https://developer.android.com/distribute/best-practices/develop/target-sdk.html"
12-
url="https://support.google.com/googleplay/android-developer/answer/113469#targetsdk"
13-
urls="https://support.google.com/googleplay/android-developer/answer/113469#targetsdk,https://developer.android.com/distribute/best-practices/develop/target-sdk.html"
147
errorLine1=" android:targetSdkVersion=&quot;1&quot; />"
158
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
169
<location
17-
file="bazel-out/darwin_arm64-fastbuild/bin/AndroidManifest.xml"
10+
file="LibManifest.xml"
1811
line="6"
1912
column="9"/>
2013
</issue>
2114

22-
</issues>
15+
</issues>

0 commit comments

Comments
 (0)