Reduce complexity of onPlayerMove() and getWorld() by extracting helpers

AcidEffect: extracts isExemptFromAcid(), handleRainExposure(), and
startAcidBurn() from onPlayerMove() to flatten nesting and separate concerns.

AcidIsland: extracts getWorldName() and configureSpawnRates() from getWorld()
to bring each method within SonarCloud's cognitive complexity limit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: tastybento

src/main/java/world/bentobox/acidisland/AcidIsland.java

@@ -153,34 +153,29 @@ public void createWorlds() {
      * @return world loaded or generated
      */
     private World getWorld(String worldName2, Environment env, @Nullable ChunkGenerator chunkGenerator2) {
-        // Set world name
-        worldName2 = env.equals(World.Environment.NETHER) ? worldName2 + NETHER : worldName2;
-        worldName2 = env.equals(World.Environment.THE_END) ? worldName2 + THE_END : worldName2;
-        WorldCreator wc = WorldCreator.name(worldName2).environment(env).type(WorldType.NORMAL);
+        String name = getWorldName(worldName2, env);
+        WorldCreator wc = WorldCreator.name(name).environment(env).type(WorldType.NORMAL);
         World w = settings.isUseOwnGenerator() ? wc.createWorld() : wc.generator(chunkGenerator2).createWorld();
-        // Set spawn rates
         if (w != null && getSettings() != null) {
-            if (getSettings().getSpawnLimitMonsters() > 0) {
-                w.setSpawnLimit(SpawnCategory.MONSTER, getSettings().getSpawnLimitMonsters());
-            }
-            if (getSettings().getSpawnLimitAmbient() > 0) {
-                w.setSpawnLimit(SpawnCategory.AMBIENT, getSettings().getSpawnLimitAmbient());
-            }
-            if (getSettings().getSpawnLimitAnimals() > 0) {
-                w.setSpawnLimit(SpawnCategory.ANIMAL, getSettings().getSpawnLimitAnimals());
-            }
-            if (getSettings().getSpawnLimitWaterAnimals() > 0) {
-                w.setSpawnLimit(SpawnCategory.WATER_ANIMAL, getSettings().getSpawnLimitWaterAnimals());
-            }
-            if (getSettings().getTicksPerAnimalSpawns() > 0) {
-                w.setTicksPerSpawns(SpawnCategory.ANIMAL, getSettings().getTicksPerAnimalSpawns());
-            }
-            if (getSettings().getTicksPerMonsterSpawns() > 0) {
-                w.setTicksPerSpawns(SpawnCategory.MONSTER, getSettings().getTicksPerMonsterSpawns());
-            }
+            configureSpawnRates(w);
         }
         return w;
+    }
+
+    private String getWorldName(String base, Environment env) {
+        if (env.equals(World.Environment.NETHER)) return base + NETHER;
+        if (env.equals(World.Environment.THE_END)) return base + THE_END;
+        return base;
+    }
 
+    private void configureSpawnRates(World w) {
+        AISettings s = getSettings();
+        if (s.getSpawnLimitMonsters() > 0) w.setSpawnLimit(SpawnCategory.MONSTER, s.getSpawnLimitMonsters());
+        if (s.getSpawnLimitAmbient() > 0) w.setSpawnLimit(SpawnCategory.AMBIENT, s.getSpawnLimitAmbient());
+        if (s.getSpawnLimitAnimals() > 0) w.setSpawnLimit(SpawnCategory.ANIMAL, s.getSpawnLimitAnimals());
+        if (s.getSpawnLimitWaterAnimals() > 0) w.setSpawnLimit(SpawnCategory.WATER_ANIMAL, s.getSpawnLimitWaterAnimals());
+        if (s.getTicksPerAnimalSpawns() > 0) w.setTicksPerSpawns(SpawnCategory.ANIMAL, s.getTicksPerAnimalSpawns());
+        if (s.getTicksPerMonsterSpawns() > 0) w.setTicksPerSpawns(SpawnCategory.MONSTER, s.getTicksPerMonsterSpawns());
     }
 
     @Override

src/main/java/world/bentobox/acidisland/listeners/AcidEffect.java

@@ -108,58 +108,53 @@ public void onSeaBounce(PlayerMoveEvent e) {
     @EventHandler(priority = EventPriority.LOWEST, ignoreCancelled = true)
     public void onPlayerMove(PlayerMoveEvent e) {
         Player player = e.getPlayer();
-        // Fast checks
-        if ((addon.getSettings().getAcidRainDamage() == 0 && addon.getSettings().getAcidDamage() == 0)
-                || player.isDead() || player.getGameMode().equals(GameMode.CREATIVE)
+        if (isExemptFromAcid(player)) {
+            return;
+        }
+        handleRainExposure(player);
+        if (!burningPlayers.containsKey(player) && !isSafeFromAcid(player)) {
+            startAcidBurn(player);
+        }
+    }
+
+    private boolean isExemptFromAcid(Player player) {
+        return (addon.getSettings().getAcidRainDamage() == 0 && addon.getSettings().getAcidDamage() == 0)
+                || player.isDead()
+                || player.getGameMode().equals(GameMode.CREATIVE)
                 || player.getGameMode().equals(GameMode.SPECTATOR)
                 || addon.getPlayers().isInTeleport(player.getUniqueId())
                 || !Util.sameWorld(addon.getOverWorld(), player.getWorld())
                 || (!player.isOp() && player.hasPermission("acidisland.mod.noburn"))
-                || (player.isOp() && !addon.getSettings().isAcidDamageOp())) {
+                || (player.isOp() && !addon.getSettings().isAcidDamageOp());
+    }
+
+    private void handleRainExposure(Player player) {
+        if (addon.getSettings().getAcidRainDamage() <= 0D || !addon.getOverWorld().hasStorm()) {
             return;
         }
-        // Slow checks
-        // Check for acid rain
-        if (addon.getSettings().getAcidRainDamage() > 0D && addon.getOverWorld().hasStorm()) {
-            if (isSafeFromRain(player)) {
-                wetPlayers.remove(player);
-            } else if (!wetPlayers.containsKey(player)) {
-                // Start hurting them
-                // Add to the list
-                wetPlayers.put(player, System.currentTimeMillis() + addon.getSettings().getAcidDamageDelay() * 1000);
-                // This runnable continuously hurts the player even if
-                // they are not
-                // moving but are in acid rain.
-
-                new BukkitRunnable() {
-                    @Override
-                    public void run() {
-                        // Check if it is still raining or player is safe or dead or there is no damage
-                        if (checkForRain(player)) {
-                            this.cancel();
-                        }
-
+        if (isSafeFromRain(player)) {
+            wetPlayers.remove(player);
+        } else if (!wetPlayers.containsKey(player)) {
+            wetPlayers.put(player, System.currentTimeMillis() + addon.getSettings().getAcidDamageDelay() * 1000);
+            new BukkitRunnable() {
+                @Override
+                public void run() {
+                    if (checkForRain(player)) {
+                        this.cancel();
                     }
-                }.runTaskTimer(addon.getPlugin(), 0L, 20L);
-            }
-
-        }
-        // If they are already burning in acid then return
-        if (burningPlayers.containsKey(player) || isSafeFromAcid(player)) {
-            return;
+                }
+            }.runTaskTimer(addon.getPlugin(), 0L, 20L);
         }
-        // ACID!
-        // Put the player into the acid list
+    }
+
+    private void startAcidBurn(Player player) {
         burningPlayers.put(player, System.currentTimeMillis() + addon.getSettings().getAcidDamageDelay() * 1000);
-        // This runnable continuously hurts the player even if they are not
-        // moving but are in acid.
         new BukkitRunnable() {
             @Override
             public void run() {
                 if (continuouslyHurtPlayer(player)) {
                     this.cancel();
                 }
-
             }
         }.runTaskTimer(addon.getPlugin(), 0L, 20L);
     }