Remove unnecessary public modifiers from JUnit 5 test methods

JUnit 5 does not require public visibility on test, setup, or teardown
methods. Removes public from all void method declarations across 12 test
classes to address SonarCloud warnings.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: tastybento

src/test/java/world/bentobox/acidisland/AISettingsTest.java

@@ -99,7 +99,7 @@ public class AcidIslandTest {
 
     @SuppressWarnings("unchecked")
     @BeforeAll
-    public static void beforeAll() throws Exception {
+    static void beforeAll() throws Exception {
         // This has to be done beforeAll otherwise the tests will interfere with each other
         h = mock(AbstractDatabaseHandler.class);
         // Database
@@ -111,12 +111,12 @@ public static void beforeAll() throws Exception {
     }
 
     @AfterAll
-    public static void afterAll() {
+    static void afterAll() {
         mockedDbSetup.close();
     }
 
     @AfterEach
-    public void tearDown() throws IOException {
+    void tearDown() throws IOException {
         User.clearUsers();
         if (mockedBukkit != null) {
             mockedBukkit.closeOnDemand();
@@ -136,7 +136,7 @@ private void deleteAll(File file) throws IOException {
     }
 
     @BeforeEach
-    public void setUp() throws Exception {
+    void setUp() throws Exception {
         // Set up plugin via reflection
         Field instanceField = BentoBox.class.getDeclaredField("instance");
         instanceField.setAccessible(true);
@@ -221,7 +221,7 @@ public void setUp() throws Exception {
      * Test method for {@link world.bentobox.acidisland.AcidIsland#onLoad()}.
      */
     @Test
-    public void testOnLoad() {
+    void testOnLoad() {
         addon.onLoad();
         // Check that config.yml file has been saved
         File check = new File("addons/AcidIsland", "config.yml");
@@ -232,7 +232,7 @@ public void testOnLoad() {
      * Test method for {@link world.bentobox.acidisland.AcidIsland#onEnable()}.
      */
     @Test
-    public void testOnEnable() {
+    void testOnEnable() {
         testOnLoad();
         addon.onEnable();
         assertTrue(addon.getPlayerCommand().isPresent());
@@ -243,7 +243,7 @@ public void testOnEnable() {
      * Test method for {@link world.bentobox.acidisland.AcidIsland#onReload()}.
      */
     @Test
-    public void testOnReload() {
+    void testOnReload() {
         addon.onReload();
         // Check that config.yml file has been saved
         File check = new File("addons/AcidIsland", "config.yml");
@@ -254,7 +254,7 @@ public void testOnReload() {
      * Test method for {@link world.bentobox.acidisland.AcidIsland#createWorlds()}.
      */
     @Test
-    public void testCreateWorlds() {
+    void testCreateWorlds() {
         addon.onLoad();
         addon.createWorlds();
         Mockito.verify(plugin).log("[AcidIsland] Creating AcidIsland...");
@@ -266,7 +266,7 @@ public void testCreateWorlds() {
      * Test method for {@link world.bentobox.acidisland.AcidIsland#getSettings()}.
      */
     @Test
-    public void testGetSettings() {
+    void testGetSettings() {
         addon.onLoad();
         assertNotNull(addon.getSettings());
     }
@@ -275,7 +275,7 @@ public void testGetSettings() {
      * Test method for {@link world.bentobox.acidisland.AcidIsland#getWorldSettings()}.
      */
     @Test
-    public void testGetWorldSettings() {
+    void testGetWorldSettings() {
         addon.onLoad();
         assertEquals(addon.getSettings(), addon.getWorldSettings());
     }
@@ -284,7 +284,7 @@ public void testGetWorldSettings() {
      * Test method for {@link world.bentobox.acidisland.AcidIsland#getDefaultWorldGenerator(java.lang.String, java.lang.String)}.
      */
     @Test
-    public void testGetDefaultWorldGeneratorStringString() {
+    void testGetDefaultWorldGeneratorStringString() {
         assertNull(addon.getDefaultWorldGenerator("", ""));
         addon.onLoad();
         addon.createWorlds();
@@ -296,23 +296,23 @@ public void testGetDefaultWorldGeneratorStringString() {
      * Test method for {@link world.bentobox.acidisland.AcidIsland#allLoaded()}.
      */
     @Test
-    public void testAllLoaded() {
+    void testAllLoaded() {
         addon.allLoaded();
     }
 
     /**
      * Test method for {@link world.bentobox.acidisland.AcidIsland#saveWorldSettings()}.
      */
     @Test
-    public void testSaveWorldSettings() {
+    void testSaveWorldSettings() {
         addon.saveWorldSettings();
     }
 
     /**
      * Test onDisable cancels acidTask.
      */
     @Test
-    public void testOnDisable() {
+    void testOnDisable() {
         testOnEnable();
         addon.onDisable();
         // Should not throw - acidTask.cancelTasks() is called
@@ -322,7 +322,7 @@ public void testOnDisable() {
      * Test onDisable when acidTask is null (no prior onEnable).
      */
     @Test
-    public void testOnDisableNoTask() {
+    void testOnDisableNoTask() {
         // No onEnable called, acidTask is null
         addon.onDisable();
         // Should not throw
@@ -332,7 +332,7 @@ public void testOnDisableNoTask() {
      * Test onEnable does nothing when settings is null.
      */
     @Test
-    public void testOnEnableNullSettings() {
+    void testOnEnableNullSettings() {
         // Don't call onLoad, so settings is null
         addon.onEnable();
         // Should return early without registering listeners

src/test/java/world/bentobox/acidisland/AcidIslandTest.java

@@ -48,7 +48,7 @@ public class IslandAboutCommandTest {
     private IslandAboutCommand command;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         server = MockBukkit.mock();
         mockedBukkit = Mockito.mockStatic(Bukkit.class, Mockito.RETURNS_DEEP_STUBS);
         mockedBukkit.when(Bukkit::getMinecraftVersion).thenReturn("1.21.11");
@@ -71,14 +71,14 @@ public void setUp() {
     }
 
     @AfterEach
-    public void tearDown() {
+    void tearDown() {
         mockedBukkit.closeOnDemand();
         Mockito.framework().clearInlineMocks();
         MockBukkit.unmock();
     }
 
     @Test
-    public void testExecute() {
+    void testExecute() {
         boolean result = command.execute(user, "about", Collections.emptyList());
         assertTrue(result);
         verify(user, atLeastOnce()).sendRawMessage(anyString());

src/test/java/world/bentobox/acidisland/commands/IslandAboutCommandTest.java

@@ -25,62 +25,62 @@ public class AcidEventTest {
     private AcidEvent e;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         List<PotionEffectType> effects = List.of();
         e = new AcidEvent(player, 10, 5, effects);
     }
 
     @Test
-    public void testAcidEvent() {
+    void testAcidEvent() {
         assertNotNull(e);
     }
 
     @Test
-    public void testGetPlayer() {
+    void testGetPlayer() {
         assertEquals(player, e.getPlayer());
     }
 
     @Test
-    public void testSetPlayer() {
+    void testSetPlayer() {
         Player player2 = mock(Player.class);
         e.setPlayer(player2);
         assertEquals(player2, e.getPlayer());
     }
 
     @Test
-    public void testGetTotalDamage() {
+    void testGetTotalDamage() {
         assertEquals(10D, e.getTotalDamage(), 0D);
     }
 
     @Test
-    public void testGetProtection() {
+    void testGetProtection() {
         assertEquals(5D, e.getProtection(), 0D);
     }
 
     @Test
-    public void testSetTotalDamage() {
+    void testSetTotalDamage() {
         e.setTotalDamage(50);
         assertEquals(50D, e.getTotalDamage(), 0D);
     }
 
     @Test
-    public void testGetPotionEffects() {
+    void testGetPotionEffects() {
         assertEquals(0, e.getPotionEffects().toArray().length);
     }
 
     @Test
-    public void testSetPotionEffects() {
+    void testSetPotionEffects() {
         e.setPotionEffects(new ArrayList<>());
         assertTrue(e.getPotionEffects().isEmpty());
     }
 
     @Test
-    public void testIsCancelled() {
+    void testIsCancelled() {
         assertFalse(e.isCancelled());
     }
 
     @Test
-    public void testSetCancelled() {
+    void testSetCancelled() {
         e.setCancelled(true);
         assertTrue(e.isCancelled());
         e.setCancelled(false);

src/test/java/world/bentobox/acidisland/events/AcidEventTest.java

@@ -25,62 +25,62 @@ public class AcidRainEventTest {
     private AcidRainEvent e;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         List<PotionEffectType> effects = List.of();
         e = new AcidRainEvent(player, 10, 5, effects);
     }
 
     @Test
-    public void testAcidEvent() {
+    void testAcidEvent() {
         assertNotNull(e);
     }
 
     @Test
-    public void testGetPlayer() {
+    void testGetPlayer() {
         assertEquals(player, e.getPlayer());
     }
 
     @Test
-    public void testSetPlayer() {
+    void testSetPlayer() {
         Player player2 = mock(Player.class);
         e.setPlayer(player2);
         assertEquals(player2, e.getPlayer());
     }
 
     @Test
-    public void testGetTotalDamage() {
+    void testGetTotalDamage() {
         assertTrue(e.getRainDamage() == 10D);
     }
 
     @Test
-    public void testGetProtection() {
+    void testGetProtection() {
         assertTrue(e.getProtection() == 5D);
     }
 
     @Test
-    public void testSetTotalDamage() {
+    void testSetTotalDamage() {
         e.setRainDamage(50);
         assertTrue(e.getRainDamage() == 50D);
     }
 
     @Test
-    public void testGetPotionEffects() {
+    void testGetPotionEffects() {
         assertEquals(0, e.getPotionEffects().toArray().length);
     }
 
     @Test
-    public void testSetPotionEffects() {
+    void testSetPotionEffects() {
         e.setPotionEffects(new ArrayList<>());
         assertTrue(e.getPotionEffects().isEmpty());
     }
 
     @Test
-    public void testIsCancelled() {
+    void testIsCancelled() {
         assertFalse(e.isCancelled());
     }
 
     @Test
-    public void testSetCancelled() {
+    void testSetCancelled() {
         e.setCancelled(true);
         assertTrue(e.isCancelled());
         e.setCancelled(false);

src/test/java/world/bentobox/acidisland/events/AcidRainEventTest.java

@@ -23,64 +23,64 @@ public class EntityDamageByAcidEventTest {
     private EntityDamageByAcidEvent rainEvent;
 
     @BeforeEach
-    public void setUp() {
+    void setUp() {
         waterEvent = new EntityDamageByAcidEvent(entity, 10.0, Acid.WATER);
         rainEvent = new EntityDamageByAcidEvent(entity, 5.0, Acid.RAIN);
     }
 
     @Test
-    public void testConstructor() {
+    void testConstructor() {
         assertNotNull(waterEvent);
         assertNotNull(rainEvent);
     }
 
     @Test
-    public void testGetEntity() {
+    void testGetEntity() {
         assertEquals(entity, waterEvent.getEntity());
     }
 
     @Test
-    public void testGetDamage() {
+    void testGetDamage() {
         assertEquals(10.0, waterEvent.getDamage(), 0D);
         assertEquals(5.0, rainEvent.getDamage(), 0D);
     }
 
     @Test
-    public void testSetDamage() {
+    void testSetDamage() {
         waterEvent.setDamage(25.0);
         assertEquals(25.0, waterEvent.getDamage(), 0D);
     }
 
     @Test
-    public void testGetCauseWater() {
+    void testGetCauseWater() {
         assertEquals(Acid.WATER, waterEvent.getCause());
     }
 
     @Test
-    public void testGetCauseRain() {
+    void testGetCauseRain() {
         assertEquals(Acid.RAIN, rainEvent.getCause());
     }
 
     @Test
-    public void testIsCancelled() {
+    void testIsCancelled() {
         assertFalse(waterEvent.isCancelled());
     }
 
     @Test
-    public void testSetCancelled() {
+    void testSetCancelled() {
         waterEvent.setCancelled(true);
         assertTrue(waterEvent.isCancelled());
         waterEvent.setCancelled(false);
         assertFalse(waterEvent.isCancelled());
     }
 
     @Test
-    public void testGetHandlers() {
+    void testGetHandlers() {
         assertNotNull(waterEvent.getHandlers());
     }
 
     @Test
-    public void testGetHandlerList() {
+    void testGetHandlerList() {
         assertNotNull(EntityDamageByAcidEvent.getHandlerList());
     }
 }