Release 1.21.0#168
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace PowerMockRunner with MockitoExtension, PowerMockito.mockStatic with Mockito.mockStatic (AutoCloseable), and Whitebox with reflection. Update POM to Paper 1.21.11, Mockito 5.17, JUnit 5.12, and MockBukkit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
New test files: EntityDamageByAcidEventTest, ItemDestroyByAcidEventTest, AcidBiomeProviderTest, IslandAboutCommandTest. Augmented AcidEffectTest, AcidTaskTest, and AcidIslandTest with additional branch/condition tests. Total tests: 275 -> 314. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Converts all 19 locale files from legacy Bukkit & color codes to Adventure MiniMessage tags (&1 → <dark_blue>, &c → <red>). Also fixes several pre-existing bugs: full-width ampersand in ja.yml, broken placeholder names in vi.yml ([tên]), hr.yml ([Ime]) and tr.yml ([isim]) standardised to [name], missing <red><3 in pl.yml, and a space in the color code in tr.yml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ations Migrate locale files from legacy color codes to MiniMessage format
Updates api-version in addon.yml and bentobox.version in pom.xml to 3.12.0 to reflect the minimum BentoBox version required for MiniMessage locale formatting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Release update aligning AcidIsland with newer platform/library versions and modernizing the test suite (JUnit 5 + Mockito static mocking), plus minor runtime and locale tweaks.
Changes:
- Migrate unit tests from JUnit 4/PowerMock to JUnit 5 + Mockito (including new/additional tests).
- Update build/dependencies for BentoBox 3.12.0 and add MockBukkit/JUnit5/Mockito-related configuration.
- Adjust sign locale formatting (MiniMessage-style tags) and harden Essentials god-mode lookup against null user.
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/world/bentobox/acidisland/world/ChunkGeneratorWorldTest.java | Migrates test to JUnit 5 + Mockito extension. |
| src/test/java/world/bentobox/acidisland/world/AcidTaskTest.java | Migrates to JUnit 5, replaces PowerMock static mocking with Mockito, adds coverage. |
| src/test/java/world/bentobox/acidisland/world/AcidBiomeProviderTest.java | Adds JUnit 5 coverage for biome selection. |
| src/test/java/world/bentobox/acidisland/mocks/ServerMocks.java | Avoids reinitializing Bukkit singleton server across tests. |
| src/test/java/world/bentobox/acidisland/listeners/LavaCheckTest.java | Migrates to JUnit 5 and Mockito static mocking with proper cleanup. |
| src/test/java/world/bentobox/acidisland/listeners/AcidEffectTest.java | Migrates to JUnit 5, replaces PowerMock, adds coverage tests. |
| src/test/java/world/bentobox/acidisland/events/ItemDestroyByAcidEventTest.java | Adds basic JUnit 5 coverage for event accessors/handlers. |
| src/test/java/world/bentobox/acidisland/events/EntityDamageByAcidEventTest.java | Adds JUnit 5 coverage for cancellable damage event behavior. |
| src/test/java/world/bentobox/acidisland/events/AcidRainEventTest.java | Migrates to JUnit 5 assertions/annotations. |
| src/test/java/world/bentobox/acidisland/events/AcidEventTest.java | Migrates to JUnit 5 assertions/annotations. |
| src/test/java/world/bentobox/acidisland/commands/IslandAboutCommandTest.java | Adds JUnit 5 coverage for command execution messaging. |
| src/test/java/world/bentobox/acidisland/AISettingsTest.java | Migrates large settings test suite to JUnit 5. |
| src/test/java/world/bentobox/acidisland/AcidIslandTest.java | Migrates to JUnit 5, replaces Whitebox/PowerMock with reflection + Mockito static mocks, adds coverage. |
| src/main/resources/locales/zh-CN.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/vi.yml | Updates sign formatting + placeholder normalization. |
| src/main/resources/locales/uk.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/tr.yml | Fixes sign lines + formatting tags. |
| src/main/resources/locales/ru.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/ro.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/pl.yml | Updates sign formatting + restores missing line3 content. |
| src/main/resources/locales/lv.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/ko.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/ja.yml | Fixes sign formatting and ordering. |
| src/main/resources/locales/it.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/id.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/hu.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/hr.yml | Updates sign formatting + placeholder normalization. |
| src/main/resources/locales/fr.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/es.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/en-US.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/de.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/locales/cs.yml | Updates sign formatting to MiniMessage-style tags. |
| src/main/resources/addon.yml | Bumps addon api-version to 3.12.0. |
| src/main/java/world/bentobox/acidisland/listeners/AcidEffect.java | Prevents NPE if Essentials returns null user. |
| pom.xml | Updates dependency set (JUnit 5/Mockito/MockBukkit), bumps versions, adds jitpack repo. |
| CLAUDE.md | Adds repo guidance file (but contains outdated testing info). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Switch from spigot-api to paper-api 1.21.11-R0.1-SNAPSHOT (provided) - Add MockBukkit v1.21-SNAPSHOT for tests; delete ServerMocks utility class - Exclude MockBukkit's JUnit 6 transitive deps to avoid version conflicts - Migrate all 8 test classes to MockBukkit.mock()/unmock() pattern with explicit Bukkit::getMinecraftVersion stub (required by BentoBox 3.12.0) - Remove clearInlineMocks() from @AfterEach (broke @BeforeAll mocks) - Fix AcidEffectTest: remove uncompilable inner Att class; use mock(AttributeInstance) - Fix AcidEffectTest: use null slot instead of new ItemStack(AIR) for partial armor - Fix AcidTaskTest: expect any(Sound.class) not null for playSound assertion - Fix AISettingsTest: use string literal instead of Flags.ANIMAL_NATURAL_SPAWN.getID() - Update Maven plugin versions to match current best practice All 314 tests pass (5 skipped, 0 failures, 0 errors) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Introduces a third overworld starter option themed around cherry blossoms and 1.21 blocks. Features a hidden tuff-brick sanctum accessed via a discoverable oak trapdoor, lit by a copper bulb, with a crafter and decorated pot as secondary containers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Publishes the AcidIsland JAR to Modrinth on GitHub release or manual workflow_dispatch trigger. Requires MODRINTH_TOKEN and MODRINTH_PROJECT_ID repository secrets. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.