Release 1.22.0#169
Merged
Merged
Conversation
JUnit 5 does not require public visibility on test, setup, or teardown methods. Removes public from all void method declarations across 12 test classes to address SonarCloud warnings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces bare method calls with assertDoesNotThrow() to make the "should not throw" intent explicit and satisfy SonarCloud's "add at least one assertion" rule. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Splits the single large method into makeBedrockLayers(), makeNetherrackLayers(), makeGlowstoneLayer(), and placeGlowstoneBlob() to satisfy SonarCloud's cognitive complexity limit. Also fixes a copy-paste bug in glowstone blob case 3 where z - xx was used instead of z - zz. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Extracts isAcidSusceptible() and addToBurnList() from findEntities() to reduce cognitive complexity and improve readability. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AcidEffect: extracts isExemptFromAcid(), handleRainExposure(), and startAcidBurn() from onPlayerMove() to flatten nesting and separate concerns. AcidIsland: extracts getWorldName() and configureSpawnRates() from getWorld() to bring each method within SonarCloud's cognitive complexity limit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ItemFillWithAcidEvent, PlayerDrinkAcidEvent: add since+forRemoval. AISettings.getDefaultIslandFlags/Settings: add missing @deprecated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…785) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace containsKey+put with putIfAbsent for the wet-players guard. Replace Math.max(0,Math.min(100,...)) with Math.clamp in both damage percent calculations (rain and acid). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…S6201, S1130) AcidTask.applyDamage: replace instanceof+cast with pattern variables. AISettingsTest.setUp: remove 'throws Exception' that can never be thrown. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ChunkGeneratorWorldTest: remove unused Mockito class import. LavaCheckTest: remove eq() wrappers on concrete verify arguments and the now-unused eq import. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents JUnit 5 style rules (no public modifier, assertDoesNotThrow, assertEquals, @disabled reason, no eq() on concrete values), Java 21 idioms flagged by Sonar (pattern instanceof, Math.clamp, putIfAbsent, @deprecated with since/forRemoval), and the SonarCloud API query for fetching open issues without a browser. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Acid water: glass bottles filled from ocean/acid cauldron become Potion of Poison (red lore); water buckets filled in the acid world get acid tag - Purified water: obtained via dripstone cauldron, furnace smelting, or brewing with coal — becomes Potion of Healing (green lore) - Cauldron purity tracked in-memory and persisted to cauldrons.yml across restarts; dripstone vs rain distinguished by block scan above cauldron - Furnace recipe uses ExactChoice to prevent non-water potions cooking - Ocean bottle fill uses post-hoc next-tick replacement (Paper fires the interact event as RIGHT_CLICK_AIR pre-cancelled for fluid blocks) - BentoBox upgraded to 3.14.0-SNAPSHOT; lore via MiniMessage/locale system Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Purified bottles revert to PotionType.WATER so they work as brewing stand base ingredients; add PlayerItemConsumeEvent handler to apply configurable health boost (getPurifiedWaterHeal()) on drink - onBucketFill now checks cauldron purity: purified cauldron yields a purified bucket, acid cauldron/ocean yields an acid bucket - Add acid bucket lore (makeAcidBucket) for ocean bucket fills - 7 new tests covering drink-heal, max-health cap, cancellable event, and cauldron-purity bucket routing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Closed
2 tasks
Contributor
There was a problem hiding this comment.
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.