Fix duplicate permission keys in addon.yml (1.22.1)#171
Merged
Conversation
Several commands share a single permission node (e.g. /ai ban, /ai unban and /ai banlist all use acidisland.island.ban), but these were written as separate YAML entries with identical keys. YAML collapses duplicate keys to the last entry and the server logs "duplicate keys found" warnings on load. Consolidate each shared node into a single entry with a combined description, matching the BSkyBlock convention. Affected nodes: island.name, island.ban, island.team.coop/trust/promote, admin.tp, mod.team.add/disband/fix/kick/setowner, and admin.resets.remove. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Server 26.2 logs
duplicate keys foundwarnings on load:These keys are permission nodes in
src/main/resources/addon.yml, not the locale files. Several commands legitimately share one permission node (e.g./ai ban,/ai unban,/ai banlistall useacidisland.island.ban), but they had been written as separate YAML entries with identical keys. YAML collapses duplicate keys to the last one — so earlier descriptions were silently dropped — and emits the warning.Fix
Consolidate each shared node into a single entry with a combined description, matching the BSkyBlock convention. Affected nodes:
acidisland.island.name(setname / resetname)acidisland.island.ban(ban / unban / banlist)acidisland.island.team.coop/.trust/.promoteacidisland.admin.tp(tp / tpnether / tpend)acidisland.mod.team.add/.disband/.fix/.kick/.setowneracidisland.admin.resets.remove(resets reset / resets remove)Verified against BentoBox core that
/acid resets resetand/acid resets removegenuinely shareadmin.resets.remove(AdminResetsResetCommandcallssetPermission("admin.resets.remove")), so the node is kept rather than split. The locale files themselves had no duplicate keys.Bumps version to 1.22.1.
🤖 Generated with Claude Code