Address PR #66 review: localize latest-transaction placeholder, harden history parsing

- PhManager: the _latest_transaction placeholder now localizes transaction
  type names via the existing bank.statement.* locale keys (reused from
  StatementTab) instead of returning hardcoded English. User is threaded
  through formatTransaction/getTxTypeDisplay.
- BankManager: extract shared parseEntry() helper so getHistory() and
  getLatestHistory() parse stored entries identically. getLatestHistory no
  longer casts the history Map to NavigableMap — that cast risked a
  ClassCastException when Gson deserializes the map from the database into a
  non-TreeMap; instead find the latest key via Collections.max.
- PhManagerTest: stub user.getTranslation for the statement keys and assert
  on the localized output.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: tastybento

src/main/java/world/bentobox/bank/BankManager.java

@@ -318,19 +318,31 @@ public List<AccountHistory> getHistory(Island island) {
             BankAccounts account = getAccount(island.getUniqueId());
             // Calculate interest
             this.getBalancePlusInterest(account);
-            return account.getHistory().entrySet().stream().map(en -> {
-                String[] split = en.getValue().split(":");
-                if (split.length == 3) {
-                    TxType type = Enums.getIfPresent(TxType.class, split[1]).or(TxType.UNKNOWN);
-                    return new AccountHistory(en.getKey(), split[0], Double.parseDouble(split[2]), type);
-                }
-                return null;
-            }).filter(Objects::nonNull).toList();
+            return account.getHistory().entrySet().stream().map(en -> parseEntry(en.getKey(), en.getValue()))
+                    .filter(Objects::nonNull).toList();
         } catch (IOException e) {
             return Collections.emptyList();
         }
     }
 
+    /**
+     * Parse a single stored history entry ({@code name:type:amount}) into an {@link AccountHistory}.
+     * @param key - timestamp key
+     * @param value - stored value
+     * @return parsed {@link AccountHistory} or null if the value is malformed
+     */
+    private AccountHistory parseEntry(Long key, String value) {
+        if (value == null) return null;
+        String[] split = value.split(":");
+        if (split.length != 3) return null;
+        TxType type = Enums.getIfPresent(TxType.class, split[1]).or(TxType.UNKNOWN);
+        try {
+            return new AccountHistory(key, split[0], Double.parseDouble(split[2]), type);
+        } catch (NumberFormatException e) {
+            return null;
+        }
+    }
+
     /**
      * Get the latest transaction history entry for an island
      * @param island - island
@@ -343,24 +355,12 @@ public AccountHistory getLatestHistory(Island island) {
             // Keep behavior consistent with getHistory(): apply interest before reading history
             this.getBalancePlusInterest(account);
 
+            // Find the most recent entry by timestamp key. Don't assume the concrete Map type:
+            // when loaded from the database Gson may not preserve the TreeMap, so avoid casting to NavigableMap.
             Map<Long, String> history = account.getHistory();
             if (history.isEmpty()) return null;
-
-            java.util.Map.Entry<Long, String> latest = ((java.util.NavigableMap<Long, String>) history).lastEntry();
-            if (latest == null || latest.getValue() == null) return null;
-
-            Long latestKey = latest.getKey();
-            String value = latest.getValue();
-
-            String[] split = value.split(":", 3);
-            if (split.length != 3) return null;
-
-            TxType type = Enums.getIfPresent(TxType.class, split[1]).or(TxType.UNKNOWN);
-            try {
-                return new AccountHistory(latestKey, split[0], Double.parseDouble(split[2]), type);
-            } catch (NumberFormatException e) {
-                return null;
-            }
+            Long latestKey = Collections.max(history.keySet());
+            return parseEntry(latestKey, history.get(latestKey));
         } catch (IOException e) {
             return null;
         }

src/main/java/world/bentobox/bank/PhManager.java

@@ -128,37 +128,38 @@ String getLatestTransaction(User user, World world) {
         if (user == null || !user.isPlayer() || world == null) return "";
         Island island = addon.getIslands().getIsland(world, user);
         if (island == null) return "";
-        return formatTransaction(bankManager.getLatestHistory(island));
+        return formatTransaction(user, bankManager.getLatestHistory(island));
     }
 
     /**
      * Format an AccountHistory entry as "[Name] [TxType] [Amount]"
+     * @param user - user, used to localise the transaction type
      * @param history - the account history entry
      * @return formatted string or empty string if null
      */
-    private String formatTransaction(AccountHistory history) {
+    private String formatTransaction(User user, AccountHistory history) {
         if (history == null) return "";
-        return history.getName() + " " + getTxTypeDisplay(history.getType()) + " " + addon.getVault().format(history.getAmount());
+        return history.getName() + " " + getTxTypeDisplay(user, history.getType()) + " " + addon.getVault().format(history.getAmount());
     }
 
     /**
-     * Get display-friendly name for transaction type
+     * Get the localised, display-friendly name for a transaction type. Reuses the
+     * same {@code bank.statement.*} locale keys as the statement panel.
+     * @param user - user whose locale is used
      * @param type - transaction type
-     * @return display name
+     * @return localised display name
      */
-    private String getTxTypeDisplay(TxType type) {
-        if (type == null) {
-            return "Unknown";
-        }
-        return switch (type) {
-        case DEPOSIT -> "Deposited";
-        case WITHDRAW -> "Withdrew";
-        case GIVE -> "Received";
-        case TAKE -> "Lost";
-        case SET -> "Set";
-        case INTEREST -> "Earned";
-        default -> "Unknown";
+    private String getTxTypeDisplay(User user, TxType type) {
+        String key = switch (type == null ? TxType.UNKNOWN : type) {
+        case DEPOSIT -> "deposit";
+        case WITHDRAW -> "withdrawal";
+        case GIVE -> "give";
+        case TAKE -> "take";
+        case SET -> "set";
+        case INTEREST -> "interest";
+        default -> "unknown";
         };
+        return user.getTranslation("bank.statement." + key);
     }
 
     /**

src/test/java/world/bentobox/bank/PhManagerTest.java

@@ -106,6 +106,16 @@ public void setUp() {
         when(plm.getName(any())).thenAnswer(arg -> arg.getArgument(0, UUID.class).toString());
         when(user.isPlayer()).thenReturn(true);
         when(im.getIsland(any(World.class), any(User.class))).thenReturn(island);
+        // Localised transaction type names (see bank.statement.* in the locale files)
+        when(user.getTranslation(anyString())).thenAnswer(arg -> switch (arg.getArgument(0, String.class)) {
+        case "bank.statement.deposit" -> "Deposit";
+        case "bank.statement.withdrawal" -> "Withdrawal";
+        case "bank.statement.interest" -> "Interest";
+        case "bank.statement.give" -> "Admin Give";
+        case "bank.statement.take" -> "Admin Take";
+        case "bank.statement.set" -> "Admin Set";
+        default -> "Unknown Type";
+        });
         pm = new PhManager(addon, bm);
     }
 
@@ -312,7 +322,7 @@ void testCheckCacheOutOfBounds() {
     void testGetLatestTransactionDeposit() {
         AccountHistory ah = new AccountHistory(System.currentTimeMillis(), "tastybento", 500.0, TxType.DEPOSIT);
         when(bm.getLatestHistory(eq(island))).thenReturn(ah);
-        assertEquals("tastybento Deposited $500.0", pm.getLatestTransaction(user, world));
+        assertEquals("tastybento Deposit $500.0", pm.getLatestTransaction(user, world));
     }
 
     /**
@@ -322,7 +332,7 @@ void testGetLatestTransactionDeposit() {
     void testGetLatestTransactionWithdraw() {
         AccountHistory ah = new AccountHistory(System.currentTimeMillis(), "tastybento", 200.0, TxType.WITHDRAW);
         when(bm.getLatestHistory(eq(island))).thenReturn(ah);
-        assertEquals("tastybento Withdrew $200.0", pm.getLatestTransaction(user, world));
+        assertEquals("tastybento Withdrawal $200.0", pm.getLatestTransaction(user, world));
     }
 
     /**