Fix: skip InvincibleVisitors targeting cancellation for XP orbs

Agent-Logs-Url: https://github.com/BentoBoxWorld/BentoBox/sessions/19b02680-6fb9-456c-9cae-a1c06b2d716b

Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>

Author: Copilot

src/main/java/world/bentobox/bentobox/listeners/flags/worldsettings/InvincibleVisitorsListener.java

@@ -8,6 +8,7 @@
 import org.bukkit.Material;
 import org.bukkit.Sound;
 import org.bukkit.World;
+import org.bukkit.entity.ExperienceOrb;
 import org.bukkit.entity.Player;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
@@ -185,6 +186,7 @@ public void onVisitorTargeting(EntityTargetLivingEntityEvent e)
         if (!(e.getTarget() instanceof Player p) ||
                 !this.getIWM().inWorld(world) ||
                 e.getTarget().hasMetadata("NPC") ||
+                e.getEntity() instanceof ExperienceOrb ||
                 this.getIslands().userIsOnIsland(world, User.getInstance(e.getTarget())) ||
                 this.isPvpAllowed(p.getLocation()) ||
                 e.getReason() == EntityTargetEvent.TargetReason.TARGET_DIED ||

src/test/java/world/bentobox/bentobox/listeners/flags/worldsettings/InvincibleVisitorsListenerTest.java

@@ -26,9 +26,13 @@
 import org.bukkit.Location;
 import org.bukkit.World;
 import org.bukkit.World.Environment;
+import org.bukkit.entity.ExperienceOrb;
 import org.bukkit.entity.LivingEntity;
+import org.bukkit.entity.Zombie;
 import org.bukkit.event.entity.EntityDamageEvent;
 import org.bukkit.event.entity.EntityDamageEvent.DamageCause;
+import org.bukkit.event.entity.EntityTargetEvent.TargetReason;
+import org.bukkit.event.entity.EntityTargetLivingEntityEvent;
 import org.bukkit.event.inventory.ClickType;
 import org.bukkit.inventory.Inventory;
 import org.bukkit.inventory.ItemStack;
@@ -291,4 +295,59 @@ void testOnVisitorGetDamageVoidPlayerHasIsland() {
         verify(im).homeTeleportAsync(any(), eq(mockPlayer));
         verify(pim).callEvent(any(InvincibleVistorFlagDamageRemovalEvent.class));
     }
+
+    /**
+     * Test that onVisitorTargeting cancels mob targeting of a visitor when ENTITY_ATTACK is in IV settings.
+     */
+    @Test
+    void testOnVisitorTargetingCancelsMobTargeting() {
+        ivSettings.add(DamageCause.ENTITY_ATTACK.name());
+        Zombie zombie = mock(Zombie.class);
+        when(zombie.getWorld()).thenReturn(world);
+        EntityTargetLivingEntityEvent e = new EntityTargetLivingEntityEvent(zombie, mockPlayer, TargetReason.CLOSEST_PLAYER);
+        listener.onVisitorTargeting(e);
+        assertTrue(e.isCancelled());
+    }
+
+    /**
+     * Test that onVisitorTargeting does NOT cancel experience orb targeting of a visitor.
+     * XP orbs should still be able to track visitors for pickup, regardless of IV settings.
+     */
+    @Test
+    void testOnVisitorTargetingDoesNotCancelExperienceOrbTargeting() {
+        ivSettings.add(DamageCause.ENTITY_ATTACK.name());
+        ExperienceOrb orb = mock(ExperienceOrb.class);
+        when(orb.getWorld()).thenReturn(world);
+        EntityTargetLivingEntityEvent e = new EntityTargetLivingEntityEvent(orb, mockPlayer, TargetReason.CLOSEST_PLAYER);
+        listener.onVisitorTargeting(e);
+        assertFalse(e.isCancelled());
+    }
+
+    /**
+     * Test that onVisitorTargeting does not cancel when entity_attack is not in IV settings.
+     */
+    @Test
+    void testOnVisitorTargetingNotInIvSettings() {
+        // ENTITY_ATTACK is not in ivSettings by default
+        Zombie zombie = mock(Zombie.class);
+        when(zombie.getWorld()).thenReturn(world);
+        EntityTargetLivingEntityEvent e = new EntityTargetLivingEntityEvent(zombie, mockPlayer, TargetReason.CLOSEST_PLAYER);
+        listener.onVisitorTargeting(e);
+        assertFalse(e.isCancelled());
+    }
+
+    /**
+     * Test that onVisitorTargeting does not cancel when user is on their own island.
+     */
+    @Test
+    void testOnVisitorTargetingNotVisitor() {
+        ivSettings.add(DamageCause.ENTITY_ATTACK.name());
+        when(im.userIsOnIsland(any(), any())).thenReturn(true);
+        Zombie zombie = mock(Zombie.class);
+        when(zombie.getWorld()).thenReturn(world);
+        EntityTargetLivingEntityEvent e = new EntityTargetLivingEntityEvent(zombie, mockPlayer, TargetReason.CLOSEST_PLAYER);
+        listener.onVisitorTargeting(e);
+        assertFalse(e.isCancelled());
+    }
+
 }