Skip to content

Purge region files for soft-deleted islands #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastybento merged 21 commits into from
Apr 14, 2026

Add PURGED event reason; fire DELETED immediately on soft-delete; fix…

68a7a54
Select commit
Loading
Failed to load commit list.
Merged

Purge region files for soft-deleted islands #2933

Add PURGED event reason; fire DELETED immediately on soft-delete; fix…
68a7a54
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 14, 2026 in 56s

Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.8% Coverage on New Code
2.7% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 369 in src/main/java/world/bentobox/bentobox/managers/PurgeRegionsService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC9T4DHL4DET9q7l&open=AZ13dC9T4DHL4DET9q7l&pullRequest=2933

Check failure on line 257 in src/main/java/world/bentobox/bentobox/managers/PurgeRegionsService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Island ID " 3 times. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC9T4DHL4DET9q7j&open=AZ13dC9T4DHL4DET9q7j&pullRequest=2933

Check warning on line 11 in src/test/java/world/bentobox/bentobox/api/commands/admin/purge/AdminPurgeDeletedCommandTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.mockito.Mockito.times'. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ2L9PePpWqvzbqKjAqD&open=AZ2L9PePpWqvzbqKjAqD&pullRequest=2933

Check failure on line 224 in src/main/java/world/bentobox/bentobox/managers/PurgeRegionsService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC9T4DHL4DET9q7k&open=AZ13dC9T4DHL4DET9q7k&pullRequest=2933

Check failure on line 313 in src/main/java/world/bentobox/bentobox/managers/HousekeepingManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Housekeeping " 3 times. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC9e4DHL4DET9q7n&open=AZ13dC9e4DHL4DET9q7n&pullRequest=2933

Check warning on line 374 in src/main/java/world/bentobox/bentobox/managers/PurgeRegionsService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC9T4DHL4DET9q7m&open=AZ13dC9T4DHL4DET9q7m&pullRequest=2933

Check warning on line 6 in src/test/java/world/bentobox/bentobox/managers/PurgeRegionsServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.mockito.ArgumentMatchers.any'. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC8G4DHL4DET9q7b&open=AZ13dC8G4DHL4DET9q7b&pullRequest=2933

Check warning on line 328 in src/main/java/world/bentobox/bentobox/Settings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC-94DHL4DET9q7o&open=AZ13dC-94DHL4DET9q7o&pullRequest=2933

Check warning on line 1052 in src/main/java/world/bentobox/bentobox/Settings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ2L9PkQpWqvzbqKjAqE&open=AZ2L9PkQpWqvzbqKjAqE&pullRequest=2933

Check warning on line 1037 in src/main/java/world/bentobox/bentobox/Settings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC-94DHL4DET9q7p&open=AZ13dC-94DHL4DET9q7p&pullRequest=2933

Check warning on line 224 in src/test/java/world/bentobox/bentobox/managers/HousekeepingManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC8Q4DHL4DET9q7d&open=AZ13dC8Q4DHL4DET9q7d&pullRequest=2933

Check warning on line 23 in src/test/java/world/bentobox/bentobox/managers/PurgeRegionsServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'java.util.Collections'. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC8G4DHL4DET9q7c&open=AZ13dC8G4DHL4DET9q7c&pullRequest=2933

Check warning on line 613 in src/main/java/world/bentobox/bentobox/managers/PurgeRegionsService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC9T4DHL4DET9q7i&open=AZ13dC9T4DHL4DET9q7i&pullRequest=2933

Check warning on line 243 in src/main/java/world/bentobox/bentobox/managers/PurgeRegionsService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC9T4DHL4DET9q7h&open=AZ13dC9T4DHL4DET9q7h&pullRequest=2933

Check warning on line 65 in src/main/java/world/bentobox/bentobox/api/commands/admin/purge/AdminPurgeDeletedCommand.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this expression which always evaluates to "true" 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC8x4DHL4DET9q7g&open=AZ13dC8x4DHL4DET9q7g&pullRequest=2933

Check warning on line 244 in src/test/java/world/bentobox/bentobox/api/commands/admin/purge/AdminPurgeDeletedCommandTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "owner2" local variable. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC1G4DHL4DET9q7a&open=AZ13dC1G4DHL4DET9q7a&pullRequest=2933

Check warning on line 1064 in src/main/java/world/bentobox/bentobox/Settings.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ2L9PkQpWqvzbqKjAqF&open=AZ2L9PkQpWqvzbqKjAqF&pullRequest=2933

Check warning on line 244 in src/test/java/world/bentobox/bentobox/api/commands/admin/purge/AdminPurgeDeletedCommandTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "owner2". 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC1G4DHL4DET9q7Z&open=AZ13dC1G4DHL4DET9q7Z&pullRequest=2933

Check warning on line 245 in src/test/java/world/bentobox/bentobox/managers/HousekeepingManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this and every subsequent useless "eq(...)" invocation; pass the values directly. 

See more on https://sonarcloud.io/project/issues?id=BentoBoxWorld_BentoBox&issues=AZ13dC8Q4DHL4DET9q7e&open=AZ13dC8Q4DHL4DET9q7e&pullRequest=2933
View more details on SonarQubeCloud