Merged
Conversation
The minimumRank validation was clamping SETTING flags that use -1 (disabled) as their defaultRank. Since -1 is a valid disabled state for SETTING/WORLD_SETTING flags (Island.isAllowed checks >= 0), restrict the validation to PROTECTION flags only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
translateColorCodes serialises &#RRGGBB to §x§R§R§G§G§B§B (BungeeCord format) via LegacyComponentSerializer. When that string was subsequently passed to parseMiniMessageOrLegacy → legacyToMiniMessage, the &x prefix was silently ignored and each following &R digit was misread as a named colour code (&2 = dark_green, &3 = dark_aqua, …), producing completely wrong colours. Fix: after normalising § to &, detect the &x&R&R&G&G&B&B pattern in both legacyToMiniMessage and replaceLegacyCodesInline and convert it to the &#RRGGBB form that HEX_PATTERN already handles. Fixes #2943 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Files like pt_BR.yml were being silently ignored because Locale.forLanguageTag returns Locale.ROOT for underscore-separated tags. Instead, when a tag contains '_', replace it with '-', rename the file on disk to the corrected name, and load it normally. A warning is logged so server admins know the file was renamed. If a correctly-named file already exists the underscore file is skipped with a warning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The BungeeCord &x&R&R&G&G&B&B → &#RRGGBB conversion block was identical in legacyToMiniMessage and replaceLegacyCodesInline. Extract it into a private normalizeBungeeHex() method. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.