Skip to content

Fix E2E CI: pin mineflayer via committed lockfile (1.21.11 support) #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tastybento merged 1 commit into from
Jul 11, 2026
Merged

Fix E2E CI: pin mineflayer via committed lockfile (1.21.11 support) #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ jobs:
uses: actions/cache@v4
with:
path: e2e/src/test/e2e/node_modules
key: e2e-npm-${{ hashFiles('e2e/src/test/e2e/package.json') }}
# Key on the committed lockfile so the cache tracks the exact resolved versions
# (mineflayer/minecraft-data must support the target Minecraft version).
key: e2e-npm-${{ hashFiles('e2e/src/test/e2e/package-lock.json') }}

- name: Build Challenges jar (Maven)
run: mvn -B -DskipTests package
Expand Down
3 changes: 2 additions & 1 deletion e2e/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ build/
# Node / TypeScript test artifacts
src/test/e2e/node_modules/
src/test/e2e/dist/
src/test/e2e/package-lock.json
# package-lock.json IS committed — it pins mineflayer/minecraft-data to versions that
# support the target Minecraft version, so CI installs are reproducible.
Loading
Loading