Remember injected types and reuse in GetIl2CppTypeFullName#103
Open
mayer-ch wants to merge 2 commits intoBepInEx:masterfrom
Open
Remember injected types and reuse in GetIl2CppTypeFullName#103mayer-ch wants to merge 2 commits intoBepInEx:masterfrom
mayer-ch wants to merge 2 commits intoBepInEx:masterfrom
Conversation
dlbuhtig4096
pushed a commit
to dlbuhtig4096/Il2CppInterop
that referenced
this pull request
Sep 28, 2023
Member
|
What was the use case for this change? |
Author
|
I forgott to fill the description sorry. Had a small discussion about this in the discord: The discrod link for reference: |
36d079d to
ad9b16f
Compare
Author
|
Updated the description |
Collaborator
|
@sir0x1 can you rebase this pull request and verify that it still has your intended behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Injecting a class derived from an existing generic class with a virtual method using the generic type as parameter currently doesn't work.
I had to fix some void* handling for this sample to work as well.
Can be reprodused with this sample plugin:
Before:

After:
