Skip to content

Commit 989008e

Browse files
justus-springerBergschaf
authored andcommitted
doc(RingTheory/Extension/Generators): fix docstring variable name mismatch (leanprover-community#39705)
Fix a mismatch between documentation and code. The field is called `ι`, not `vars.
1 parent bb712b6 commit 989008e

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

Mathlib/RingTheory/Extension/Generators.lean

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ public import Mathlib.RingTheory.Extension.Basic
1818
## Main definition
1919
2020
- `Algebra.Generators`: A family of generators of an `R`-algebra `S` consists of
21-
1. `vars`: The type of variables.
22-
2. `val : vars → S`: The assignment of each variable to a value.
21+
1. `ι`: The type of variables.
22+
2. `val : ι → S`: The assignment of each variable to a value.
2323
3. `σ`: A set-theoretic section of the induced `R`-algebra homomorphism `R[X] → S`, where we
24-
write `R[X]` for `R[vars]`.
24+
write `R[X]` for `R[ι]`.
2525
2626
- `Algebra.Generators.Hom`: Given a commuting square
2727
```
@@ -37,11 +37,11 @@ public import Mathlib.RingTheory.Extension.Basic
3737
3838
## TODOs
3939
40-
Currently, Lean does not see through the `vars` field of terms of `Generators R S` obtained
40+
Currently, Lean does not see through the `ι` field of terms of `Generators R S` obtained
4141
from constructions, e.g. composition. This causes fragile and cumbersome proofs, because
4242
`simp` and `rw` often don't work properly. `Generators R S` (and `Presentation R S`, etc.) should
4343
be refactored in a way that makes these equalities reducibly def-eq, for example
44-
by unbundling the `vars` field or making the field globally reducible in constructions using
44+
by unbundling the `ι` field or making the field globally reducible in constructions using
4545
unification hints.
4646
4747
-/
@@ -55,8 +55,8 @@ open TensorProduct MvPolynomial
5555
variable (R : Type u) (S : Type v) (ι : Type w) [CommRing R] [CommRing S] [Algebra R S]
5656

5757
/-- A family of generators of an `R`-algebra `S` consists of
58-
1. `vars`: The type of variables.
59-
2. `val : vars → S`: The assignment of each variable to a value in `S`.
58+
1. `ι`: The type of variables.
59+
2. `val : ι → S`: The assignment of each variable to a value in `S`.
6060
3. `σ`: A section of `R[X] → S`. -/
6161
structure Algebra.Generators where
6262
/-- The assignment of each variable to a value in `S`. -/
@@ -315,7 +315,7 @@ lemma extend_val_inl (P : Generators R S ι) (b : ι' → S) (i : ι) :
315315
lemma extend_val_inr (P : Generators R S ι) (b : ι' → S) (i : ι') :
316316
(P.extend b).val (.inr i) = b i := rfl
317317

318-
/-- Given generators `P` and an equivalence `ι ≃ P.vars`, these
318+
/-- Given generators `P` with variable type `ι'` and an equivalence `ι ≃ ι'`, these
319319
are the induced generators indexed by `ι`. -/
320320
noncomputable def reindex (P : Generators R S ι') (e : ι ≃ ι') :
321321
Generators R S ι where
@@ -713,7 +713,7 @@ def kerCompPreimage (Q : Generators S T ι') (P : Generators R S ι) (x : Q.ker)
713713
(Q.comp P).ker := by
714714
refine ⟨x.1.sum fun n r ↦ ?_, ?_⟩
715715
· -- The use of `refine` is intentional to control the elaboration order
716-
-- so that the term has type `(Q.comp P).Ring` and not `MvPolynomial (Q.vars ⊕ P.vars) R`
716+
-- so that the term has type `(Q.comp P).Ring` and not `MvPolynomial (Q.ι ⊕ P.ι) R`
717717
refine rename ?_ (P.σ r) * monomial ?_ 1
718718
exacts [Sum.inr, n.mapDomain Sum.inl]
719719
· simp only [ker_eq_ker_aeval_val, RingHom.mem_ker]

0 commit comments

Comments
 (0)