Skip to content

Commit 6f34a03

Browse files
authored
fix: align web test fixtures with ServerProvider contract additions (#1)
- Remove obsolete props (hasMessages, scrollContainer, nowIso, etc.) from MessagesTimeline handoff test; use buildProps() spread like sibling tests. - Add slashCommands/skills empty arrays to provider fixtures in SettingsPanels.browser.tsx and composerDraftStore.test.ts to satisfy the ServerProvider schema fields added via withDecodingDefault.
1 parent 863f00c commit 6f34a03

3 files changed

Lines changed: 11 additions & 23 deletions

File tree

apps/web/src/components/chat/MessagesTimeline.test.tsx

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -164,11 +164,7 @@ describe("MessagesTimeline", () => {
164164
const { MessagesTimeline } = await import("./MessagesTimeline");
165165
const markup = renderToStaticMarkup(
166166
<MessagesTimeline
167-
hasMessages
168-
isWorking={false}
169-
activeTurnInProgress={false}
170-
activeTurnStartedAt={null}
171-
scrollContainer={null}
167+
{...buildProps()}
172168
timelineEntries={[
173169
{
174170
id: "entry-1",
@@ -187,24 +183,6 @@ describe("MessagesTimeline", () => {
187183
},
188184
},
189185
]}
190-
completionDividerBeforeEntryId={null}
191-
completionSummary={null}
192-
turnDiffSummaryByAssistantMessageId={new Map()}
193-
nowIso="2026-03-17T19:12:30.000Z"
194-
expandedWorkGroups={{}}
195-
onToggleWorkGroup={() => {}}
196-
changedFilesExpandedByTurnId={{}}
197-
onSetChangedFilesExpanded={() => {}}
198-
onOpenTurnDiff={() => {}}
199-
revertTurnCountByUserMessageId={new Map()}
200-
onRevertUserMessage={() => {}}
201-
isRevertingCheckpoint={false}
202-
onImageExpand={() => {}}
203-
activeThreadEnvironmentId={ACTIVE_THREAD_ENVIRONMENT_ID}
204-
markdownCwd={undefined}
205-
resolvedTheme="light"
206-
timestampFormat="locale"
207-
workspaceRoot={undefined}
208186
/>,
209187
);
210188

apps/web/src/components/settings/SettingsPanels.browser.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -725,6 +725,8 @@ describe("GeneralSettingsPanel observability", () => {
725725
auth: { status: "authenticated", label: "ChatGPT Pro Subscription" },
726726
checkedAt: "2026-04-04T00:00:00.000Z",
727727
models: [],
728+
slashCommands: [],
729+
skills: [],
728730
usageLimits: {
729731
updatedAt: "2026-04-04T00:00:00.000Z",
730732
windows: [
@@ -779,6 +781,8 @@ describe("GeneralSettingsPanel observability", () => {
779781
auth: { status: "authenticated", label: "Claude Pro Subscription" },
780782
checkedAt: "2026-04-04T00:00:00.000Z",
781783
models: [],
784+
slashCommands: [],
785+
skills: [],
782786
usageLimits: {
783787
updatedAt: "2026-04-04T00:00:00.000Z",
784788
windows: [
@@ -819,6 +823,8 @@ describe("GeneralSettingsPanel observability", () => {
819823
auth: { status: "authenticated" },
820824
checkedAt: "2026-04-04T00:00:00.000Z",
821825
models: [],
826+
slashCommands: [],
827+
skills: [],
822828
},
823829
],
824830
});

apps/web/src/composerDraftStore.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,8 @@ const TEST_PROVIDERS: ServerProvider[] = [
125125
{ slug: "gpt-5.4", name: "GPT-5.4", isCustom: false, capabilities: null },
126126
{ slug: "gpt-5.4-mini", name: "GPT-5.4 Mini", isCustom: false, capabilities: null },
127127
],
128+
slashCommands: [],
129+
skills: [],
128130
},
129131
{
130132
provider: "claudeAgent",
@@ -134,6 +136,8 @@ const TEST_PROVIDERS: ServerProvider[] = [
134136
status: "ready",
135137
auth: { status: "authenticated" },
136138
checkedAt: "2026-04-10T00:00:00.000Z",
139+
slashCommands: [],
140+
skills: [],
137141
models: [
138142
{
139143
slug: "claude-opus-4-6",

0 commit comments

Comments
 (0)