fix(server): resolve pre-existing typecheck drift (#2)

- CodexProvider: use conditional spread for optional `skills` so
  `exactOptionalPropertyTypes` does not surface `undefined`.
- PerfProviderRegistry: add `slashCommands: []` and `skills: []` to the
  codex and claudeAgent fixture snapshots so they satisfy ServerProvider.
- PerfProviderAdapter: add a no-op `compactThread` stub (succeeds with
  `null` for known sessions) to satisfy ProviderAdapterShape.
- PerfProviderAdapter: capture the runtime context once and use
  `Effect.runForkWith` inside the timer callback; yield tagged errors
  directly instead of wrapping them in `Effect.fail`.
- PerfProviderLayers: switch to `Layer.provideMerge` for the session
  directory so the perf provider exposes it to downstream consumers
  (matches DefaultProviderLayerLive) — this also resolves the
  `ProviderSessionDirectory` context leak flagged by cli.test.ts and
  server.ts.
- ProviderSessionReaper.test: add `stopSessionForProvider` and
  `compactThread` mocks to the mock `ProviderServiceShape`.

Co-authored-by: Claude <noreply@anthropic.com>

Author: Berkay2002

apps/server/src/perf/PerfProviderAdapter.ts

@@ -167,6 +167,8 @@ function buildRuntimeEvent(input: {
 export const makePerfProviderAdapter = Effect.gen(function* () {
   const runtimeEvents = yield* Queue.unbounded<ProviderRuntimeEvent>();
   const sessions = new Map<ThreadId, PerfSessionState>();
+  const context = yield* Effect.context<never>();
+  const runFork = Effect.runForkWith(context);
 
   const clearPendingTimers = (threadId: ThreadId) =>
     Effect.sync(() => {
@@ -189,7 +191,7 @@ export const makePerfProviderAdapter = Effect.gen(function* () {
     Effect.sync(() => {
       const timer = setTimeout(() => {
         input.state.pendingTimers.delete(timer);
-        Effect.runFork(
+        runFork(
           Queue.offer(runtimeEvents, input.event).pipe(
             Effect.tap(() => Effect.sync(() => input.onAfterEmit?.())),
             Effect.asVoid,
@@ -245,7 +247,7 @@ export const makePerfProviderAdapter = Effect.gen(function* () {
     Effect.gen(function* () {
       const state = sessions.get(input.threadId);
       if (!state) {
-        return yield* Effect.fail(sessionNotFound(input.threadId));
+        return yield* sessionNotFound(input.threadId);
       }
 
       yield* clearPendingTimers(input.threadId);
@@ -343,7 +345,7 @@ export const makePerfProviderAdapter = Effect.gen(function* () {
     Effect.gen(function* () {
       const state = sessions.get(threadId);
       if (!state) {
-        return yield* Effect.fail(sessionNotFound(threadId));
+        return yield* sessionNotFound(threadId);
       }
       yield* clearPendingTimers(threadId);
       const interruptedTurnId = turnId ?? state.session.activeTurnId;
@@ -380,12 +382,17 @@ export const makePerfProviderAdapter = Effect.gen(function* () {
   const stopSession: ProviderAdapterShape<ProviderAdapterError>["stopSession"] = (threadId) =>
     Effect.gen(function* () {
       if (!sessions.has(threadId)) {
-        return yield* Effect.fail(sessionNotFound(threadId));
+        return yield* sessionNotFound(threadId);
       }
       yield* clearPendingTimers(threadId);
       sessions.delete(threadId);
     });
 
+  const compactThread: ProviderAdapterShape<ProviderAdapterError>["compactThread"] = (threadId) =>
+    sessions.has(threadId)
+      ? Effect.succeed<string | null>(null)
+      : Effect.fail(sessionNotFound(threadId));
+
   const listSessions: ProviderAdapterShape<ProviderAdapterError>["listSessions"] = () =>
     Effect.sync(() => Array.from(sessions.values(), (state) => state.session));
 
@@ -404,7 +411,7 @@ export const makePerfProviderAdapter = Effect.gen(function* () {
     Effect.gen(function* () {
       const state = sessions.get(threadId);
       if (!state) {
-        return yield* Effect.fail(sessionNotFound(threadId));
+        return yield* sessionNotFound(threadId);
       }
       if (!Number.isInteger(numTurns) || numTurns < 0 || numTurns > state.snapshot.turns.length) {
         return yield* new ProviderAdapterValidationError({
@@ -444,6 +451,7 @@ export const makePerfProviderAdapter = Effect.gen(function* () {
     respondToRequest,
     respondToUserInput,
     stopSession,
+    compactThread,
     listSessions,
     hasSession,
     readThread,

apps/server/src/perf/PerfProviderLayers.ts

@@ -23,7 +23,7 @@ export const PerfProviderLayerLive = Layer.unwrap(
 
     return makeProviderServiceLive().pipe(
       Layer.provide(adapterRegistryLayer),
-      Layer.provide(providerSessionDirectoryLayer),
+      Layer.provideMerge(providerSessionDirectoryLayer),
     );
   }),
 );

apps/server/src/perf/PerfProviderRegistry.ts

@@ -64,6 +64,8 @@ const makeProviderSnapshot = (input: {
       checkedAt: input.checkedAt,
       message: input.enabled ? "Perf fixture provider active." : "Disabled in T3 Code settings.",
       models: CODEX_MODELS,
+      slashCommands: [],
+      skills: [],
     };
   }
 
@@ -81,6 +83,8 @@ const makeProviderSnapshot = (input: {
       ? "Perf harness only stubs Codex runtime sessions."
       : "Disabled in T3 Code settings.",
     models: CLAUDE_MODELS,
+    slashCommands: [],
+    skills: [],
   };
 };
 

apps/server/src/provider/Layers/CodexProvider.ts

@@ -399,7 +399,7 @@ export const checkCodexProviderStatus = Effect.fn("checkCodexProviderStatus")(fu
       enabled: codexSettings.enabled,
       checkedAt,
       models: input.models ?? models,
-      skills: input.skills,
+      ...(input.skills ? { skills: input.skills } : {}),
       probe: input.probe,
       ...(input.usageLimits ? { usageLimits: input.usageLimits } : {}),
     });

apps/server/src/provider/Layers/ProviderSessionReaper.test.ts

@@ -138,6 +138,8 @@ describe("ProviderSessionReaper", () => {
       respondToRequest: () => unsupported(),
       respondToUserInput: () => unsupported(),
       stopSession,
+      stopSessionForProvider: vi.fn(() => Effect.void),
+      compactThread: vi.fn(() => Effect.succeed(null)),
       listSessions: () => Effect.succeed([]),
       getCapabilities: () => Effect.succeed({ sessionModelSwitch: "in-session" }),
       rollbackConversation: () => unsupported(),