Skip to content

Trajectory module (and library) in a broken state. Unsure what version to use! #41

@where-is-atin

Description

@where-is-atin

The Issue

Hi team- What a fantastic paper!
I just want to say that I loved the binary EMBL usage and focus on both size, decoding efficiency and combining all data types together.

I would just like to report that I'm unable to use the library and I wonder if I'm doing something very wrong :)

To Reproduce
from robodm import Trajectory

Expected behavior
It should work :)

Error
NameError: name 'Fraction' is not defined

Desktop (please complete the following information):

  • OS: macOS

Additional context
So I've tried a couple things here:

  • The missing import for Fraction can be replaced, but we get another error with the CodecConfig class if we setup a trajectory
  • Looks like the there are two classes redefined (in the middle of a refactor?) in the Trajectory class, and if we comment those out (CodecConfig and TimeManager), the import and Trajectory setup succeeds
  • However, running tests shows 63F/190P, which clearly means things are not working fundamentally
  • I also checked out the commit mentioned in the README as stable (5bbb8bd), but that doesn't seem to have any robodm related code but instead has fog_x, based on parquets and polars?

Not sure what I'm doing wrong here! What version of the library should I use?
I would love to help out with fixing these if you could provide what the issues and goals are.

Cheers! And thanks again for opening up the code :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedExtra attention is needed

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions