Skip to content

Commit 513987f

Browse files
committed
fix type errors
1 parent a077b83 commit 513987f

8 files changed

Lines changed: 10 additions & 18 deletions

File tree

edg/abstract_parts/TestPoint.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Any, TypeVar, Generic
1+
from typing import Any, TypeVar, Generic, Self
22
from typing_extensions import override
33

44
from ..electronics_interfaces import *
@@ -16,7 +16,6 @@ def __init__(self, tp_name: StringLike = "") -> None:
1616

1717

1818
TestPointLinkType = TypeVar("TestPointLinkType", bound=Link)
19-
SelfType = TypeVar("SelfType", bound="BaseTypedTestPoint[Link]")
2019

2120

2221
@non_library
@@ -28,7 +27,7 @@ def __init__(self, tp_name: StringLike = "") -> None:
2827
self.io: Port[TestPointLinkType]
2928
self.tp_name = self.ArgParameter(tp_name)
3029

31-
def connected(self: SelfType, io: Port[TestPointLinkType]) -> SelfType:
30+
def connected(self, io: Port[TestPointLinkType]) -> Self:
3231
builder.block().connect(io, self.io)
3332
return self
3433

edg/circuits/LevelShifter.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,5 +86,4 @@ def generate(self) -> None:
8686
if self.get(self.hv_res) != RangeExpr.INF:
8787
self.hv_pu = self.Block(PullupResistor(self.hv_res)).connected(self.hv_pwr, self.hv_io)
8888
else:
89-
# TODO debug this type check failure
90-
self.dummy_hv = self.Block(DummyVoltageSink()).connected(self.hv_pwr) # type: ignore
89+
self.dummy_hv = self.Block(DummyVoltageSink()).connected(self.hv_pwr) # mark as connected

edg/electronics_interfaces/DummyDevices.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Dict, TypeVar, Generic
1+
from typing import Dict, TypeVar, Generic, Self
22
from typing_extensions import override
33

44
from ..electronics_model import *
@@ -7,7 +7,6 @@
77
from .AnalogPort import AnalogSink, AnalogSource, AnalogLink
88

99
DummyLinkType = TypeVar("DummyLinkType", bound=Link)
10-
SelfType = TypeVar("SelfType", bound="BaseDummyBlock[Link]")
1110

1211

1312
@non_library
@@ -18,7 +17,7 @@ def __init__(self) -> None:
1817
super().__init__()
1918
self.io: Port[DummyLinkType]
2019

21-
def connected(self: SelfType, io: Port[DummyLinkType]) -> SelfType:
20+
def connected(self, io: Port[DummyLinkType]) -> Self:
2221
builder.block().connect(io, self.io)
2322
return self
2423

edg/parts/microcontroller/Esp32.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -413,8 +413,7 @@ def generate(self) -> None:
413413
self.connect(self.gnd, self.model.gnd)
414414
self.export_tap(self.gnd, self.device.gnd)
415415
else:
416-
# TODO debug this type failure
417-
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd) # type: ignore
416+
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd)
418417

419418
if self.get(self.pwr.is_connected()): # power supplied externally
420419
self.connect(self.pwr, self.model.pwr)

edg/parts/microcontroller/Esp32c3.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -581,8 +581,7 @@ def generate(self) -> None:
581581
self.connect(self.gnd, self.model.gnd)
582582
self.export_tap(self.gnd, self.device.gnd)
583583
else:
584-
# TODO debug this type failure
585-
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd) # type: ignore
584+
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd)
586585

587586
self.connect(
588587
self.model.vdda, self.model.vdd3p3, self.model.vdd3p3_rtc, self.model.vdd3p3_cpu, self.model.vdd_spi

edg/parts/microcontroller/Esp32s3.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,7 @@ def generate(self) -> None:
393393
self.connect(self.gnd, self.model.gnd)
394394
self.export_tap(self.gnd, self.device.gnd)
395395
else:
396-
# TODO debug this type failure
397-
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd) # type: ignore
396+
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd)
398397

399398
if self.get(self.pwr.is_connected()): # power supplied externally
400399
self.connect(self.pwr, self.model.pwr)

edg/parts/microcontroller/Rp2040.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,8 +500,7 @@ def generate(self) -> None:
500500
self.connect(self.gnd, self.model.gnd)
501501
self.export_tap(self.gnd, self.device.gnd)
502502
else:
503-
# TODO debug this type failure
504-
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd) # type: ignore
503+
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd)
505504

506505
self.connect(self.model.vreg_vout, self.model.dvdd)
507506
model_pwr = self.connect(self.model.iovdd, self.model.vreg_vin, self.model.adc_avdd, self.model.usb_vdd)

edg/parts/microcontroller/nRF52840.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -710,8 +710,7 @@ def generate(self) -> None:
710710
self.connect(self.gnd, self.model.gnd)
711711
self.export_tap(self.gnd, self.device.gnd)
712712
else:
713-
# TODO debug this type failure
714-
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd) # type: ignore
713+
self.gnd_model = self.Block(DummyGround()).connected(self.model.gnd)
715714

716715
if self.get(self.pwr.is_connected()): # power supplied externally
717716
self.connect(self.pwr, self.model.pwr)

0 commit comments

Comments
 (0)