Skip to content

Commit 8fad390

Browse files
authored
PmosChargerReverseProtection shouldn't zero the output (#457)
While technically correct that it can output zero, it should instead propagate the operating voltages and assume operating conditions.
1 parent bb6e1f8 commit 8fad390

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

edg/parts/PowerConditioning.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ def contents(self) -> None:
396396
self.r1 = self.Block(Resistor(resistance=self.r1_val))
397397
self.r2 = self.Block(Resistor(resistance=self.r2_val))
398398

399-
batt_voltage = self.pwr_in.link().voltage.hull(self.chg_in.link().voltage).hull(self.gnd.link().voltage)
399+
batt_voltage = self.pwr_in.link().voltage.hull(self.chg_in.link().voltage)
400400

401401
# taking the max of the current for the both direction. 0 lower bound
402402
batt_current = self.pwr_out.link().current_drawn.hull(self.chg_out.link().current_drawn).hull((0, 0))

0 commit comments

Comments
 (0)