co_characterize: propagate a failure on any image to a failure on all images

Author: bonachea

src/julienne/julienne_test_result_m.f90

@@ -52,7 +52,7 @@ elemental module function construct_from_character(description, diagnosis) resul
     module subroutine co_characterize(self)
       !! Print a description of the test, its outcome, and diagnostic information if the test fails
       implicit none
-      class(test_result_t), intent(in) :: self
+      class(test_result_t), intent(inout) :: self
     end subroutine
 
     impure elemental module function passed(self) result(test_passed)

src/julienne/julienne_test_result_s.F90

@@ -47,7 +47,11 @@
           if (i_skipped) then
             if (me==1) print '(a)', indent // "SKIPS  on " // trim(self%description_%string()) // "."
           else
-            if (me==1) print '(a)', indent // merge("passes on ", "FAILS  on ", images_passed == images) // trim(self%description_%string()) // "."
+            if (images_passed < images .and. i_passed) then
+              ! a failure on any image becomes a failure on all images
+              self%diagnosis_ = test_diagnosis_t(test_passed=.false., diagnostics_string="peer image failure")
+            end if
+            if (me==1) print '(a)', indent // merge("passes on ", "FAILS  on ", self%diagnosis_%test_passed()) // trim(self%description_%string()) // "."
 #if ! ASYNCHRONOUS_DIAGNOSTICS
             sync all ! ensure image 1 prints test outcome before any failure diagnostics print
 #endif

src/julienne/julienne_test_s.F90

@@ -31,6 +31,7 @@
 
     integer t
     logical, allocatable :: passing_tests(:), skipped_tests(:)
+    type(test_result_t), allocatable :: test_results(:)
 
 #if HAVE_MULTI_IMAGE_SUPPORT
     associate(me => this_image())
@@ -39,16 +40,16 @@
 #endif
       if (me==1) print '(a)', new_line('') // test%subject()
 
-      associate(test_results =>  test%results())
+      test_results = test%results()
 
-        passing_tests = test_results%passed()
-        skipped_tests = test_results%skipped()
+      skipped_tests = test_results%skipped()
 
-        associate(num_tests => size(test_results))
+      associate(num_tests => size(test_results))
 
           do t = 1, num_tests
             call test_results(t)%co_characterize()
           end do
+          passing_tests = test_results%passed() ! may be altered by co_characterize
 
           tests = tests + num_tests
 
@@ -57,7 +58,6 @@
             passes = passes + num_passes
             skips  = skips  + num_skipped
           end associate
-        end associate
       end associate
     end associate
   end procedure