Remove one_image_prints_{m,s} module and submodule#125
Merged
Conversation
The primary goal of the above module's print procedures was to capture a uniform pattern for single-image printing. This commit switches to simply using that pattern everywhere single-image printing is desired. Doing so avoids the rank limitations of the removed module.
ktras
requested changes
Nov 3, 2025
Collaborator
ktras
left a comment
ktras
left a comment
There was a problem hiding this comment.
Looks great, but I think there should be one minor change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
one_image_prints_mmodule andone_image_prints_ssubmodule.The removed (sub)module contained print procedures that captured a uniform pattern for single-image printing. This commit switches to simply using that pattern everywhere single-image printing is desired. Doing so avoids the rank limitations of the removed module.
The initial inspiration for this PR came from a desire to count the number of places in which Julienne uses multi-image parallel features. The purpose of the count was to determine the amount of work that would be required to offer optional support for alternative parallel programming models such as MPI. Not counting program launch and termination, there are now only 9 places in the core library (the
srcsubdirectory) that explicitly reference multi-image features, which suggests that offering optional support for alternative parallel programming models likely requires only minimal effort.this_imagenum_imagessync allco_sum