New ways to define a test_diagnosis_t object#126
Merged
Conversation
rouson
changed the title
ktras
approved these changes
Nov 7, 2025
Collaborator
ktras
left a comment
ktras
left a comment
There was a problem hiding this comment.
LGTM except for a minor typo in a comment. Feel free to merge after accepting the suggested typo fix.
This commit adds 1. A passing_test() function that constructs a test_diagnosis_t result corresponding to a passing test 2. A test_diagnosis_t defined assignment with a logical right-hand side that determines whether the test passes or fails. Both new procedures define an object with a zero-length diagnostics string.
Co-authored-by: Katherine Rasmussen <krasmussen@lbl.gov>
rouson
force-pushed
the
assign-logical-to-test_diagnosis_t
branch
from
ae018ed to
f1ba64e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports defining a
test_diagnosis_tobject by.logical.right-hand side, e.g.,test_diagnosis = x > yortest_diagnosis = passing_test().