Skip to content

test_description_t Bless workaround#127

Merged
rouson merged 2 commits intoBerkeleyLab:mainfrom
bonachea:bless-workaround
Nov 7, 2025
Merged

test_description_t Bless workaround#127
rouson merged 2 commits intoBerkeleyLab:mainfrom
bonachea:bless-workaround

Conversation

@bonachea
Copy link
Copy Markdown
Member

@bonachea bonachea commented Nov 5, 2025

This PR adds new constructors to test_description_t that provide a more concise workaround than the current HAVE_PROCEDURE_ACTUAL_FOR_POINTER_DUMMY workaround, reducing duplicated code in the client.

The first commit deploys the machinery that enables the workaround and is the only required part. The second commit is optional and demonstrates the workaround deployment for Julienne's own tests.

Allow the procedure pointer to be passed as either a `iso_c_binding::c_funptr`
or as a `julienne_m::bless`, a trivial container helper type
Copy link
Copy Markdown
Contributor

@rouson rouson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rouson rouson merged commit b0f4227 into BerkeleyLab:main Nov 7, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants