Fix aggregate_vector_diagnosis description indent handling#147
Merged
bonachea merged 1 commit intoBerkeleyLab:mainfrom Dec 10, 2025
Merged
Conversation
Fix a bug in aggregate_vector_diagnosis that breaks Julienne diagnostic string agreggation with .also.
Currently given an incremental diagnosis pattern like this:
```fortran
diag = .true.
diag = .diag. .also. .false. // "whatever"
do i=1,100
diag = .diag. .also. .true.
end do
```
The code in aggregate_vector_diagnosis will prepend 100 `new_line_indent` strings into the diagnosis string (ie 100 blank lines), even though there was only one actual failure.
Fundamentally the problem is that a `new_line_indent` is being prepended each time `aggregate_vector_diagnosis` is called with a failing argument, even if the failing diagnosis was the outcome of a previous call to `aggregate_vector_diagnosis` that already prepended a new line.
The surgical solution in this PR prevents this defect. As a side-benefit it also provides nicer behavior if the client has formatted their own output line and already inserted a line break, eg:
```fortran
diag = test_diagnosis_t(.false.,new_line('') // " I formatted this line myself!")
```
bonachea
force-pushed
the
fix-aggregate_vector_diagnosis
branch
from
d40af91 to
b8fc996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in aggregate_vector_diagnosis that breaks Julienne diagnostic string aggregation with
.also..Currently given an incremental diagnosis pattern like this:
During the loop the code in aggregate_vector_diagnosis will prepend 100
new_line_indentstrings into the diagnosis string (ie 100 blank lines), even though there was only one actual failure.Fundamentally the problem is that a
new_line_indentis being prepended each timeaggregate_vector_diagnosisis called with a failing argument, even if the failing diagnosis was the outcome of a previous call toaggregate_vector_diagnosisthat already prepended a new line.The surgical solution in this PR prevents this defect. As a side-benefit it also provides nicer behavior if the client has formatted their own output line and already inserted a line break, eg: