Conversation
bonachea
requested changes
Dec 10, 2025
Member
bonachea
left a comment
There was a problem hiding this comment.
Does not appear to be working as intended. From CI output:
Test-suite run time: 0.10039999999999999E-2 seconds
Member
|
To be clear, that might be a reasonably accurate measurement of the running time, but it's unnecessarily difficult to read and includes a bunch of misleadingly meaningless digits that greatly exceed the actual precision of the system clock. I'd strongly prefer us to ditch the engineering notation entirely and simply print the time in decimal seconds with 3 (or at most 6) decimal places, eg: |
bonachea
reviewed
Dec 10, 2025
bonachea
approved these changes
Dec 10, 2025
Member
bonachea
left a comment
There was a problem hiding this comment.
CI confirms this now gives results like:
Test-suite run time: .016 seconds
Test-suite run time: 1.603 seconds
etc
Co-authored-by: Dan Bonachea <dobonachea@lbl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #148