Skip to content

fix(test_harness): format reported type with g0#149

Merged
bonachea merged 2 commits intomainfrom
fix-148
Dec 11, 2025
Merged

fix(test_harness): format reported type with g0#149
bonachea merged 2 commits intomainfrom
fix-148

Conversation

@rouson
Copy link
Copy Markdown
Contributor

@rouson rouson commented Dec 10, 2025

fixes #148

@rouson rouson requested a review from ktras December 10, 2025 19:57
Copy link
Copy Markdown
Member

@bonachea bonachea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not appear to be working as intended. From CI output:

Test-suite run time: 0.10039999999999999E-2 seconds

@bonachea
Copy link
Copy Markdown
Member

bonachea commented Dec 10, 2025

To be clear, that might be a reasonably accurate measurement of the running time, but it's unnecessarily difficult to read and includes a bunch of misleadingly meaningless digits that greatly exceed the actual precision of the system clock.

I'd strongly prefer us to ditch the engineering notation entirely and simply print the time in decimal seconds with 3 (or at most 6) decimal places, eg:

Test-suite run time: 0.001 seconds

Comment thread src/julienne/julienne_test_harness_s.F90 Outdated
Copy link
Copy Markdown
Member

@bonachea bonachea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI confirms this now gives results like:

Test-suite run time: .016 seconds
Test-suite run time: 1.603 seconds

etc

rouson and others added 2 commits December 10, 2025 22:14
@bonachea bonachea merged commit dd04111 into main Dec 11, 2025
54 checks passed
@bonachea bonachea deleted the fix-148 branch December 11, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Juilenne reports inflated test-suite run times

2 participants