Co-characterize failure propagation across images#150
Merged
rouson merged 2 commits intoBerkeleyLab:mainfrom Dec 10, 2025
Merged
Co-characterize failure propagation across images#150rouson merged 2 commits intoBerkeleyLab:mainfrom
rouson merged 2 commits intoBerkeleyLab:mainfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an improvement to #146 that provides a better fix to #144.
It reverts the earlier PR and provides a better solution that instead ensures that failure information propagated across images in
co_characterizeis used to update thetest_resultsarray on all images. This ensures that all images (and in particular image 1) have a global view of failures afterco_characterize. This in turn ensures that test pass tallys printed to the console (after each test and at the end of the suite) consider a test failure on any image to constitute a failure of that entire test.Fixes #144