Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR revises and reorganizes the example test suite by moving and renaming files from the "example" directory to a new "demo" directory and updating related documentation.
- The example test modules have been removed, and their functionality migrated into the new demo structure.
- A new fpm.toml file and updated documentation complete the migration, and several tests have been updated to leverage the new Julienne operators.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| example/example-test-suite/specimen_test_m.F90 | Removed as part of migration to the new demo structure |
| example/example-test-suite/scalar_and_vector_test_description_m.F90 | Removed as part of migration |
| example/README.md | Added redirect message to point users to the demo directory |
| demo/test/specimen_test_m.F90 | New test module leveraging Julienne operators and updated test logic |
| demo/src/specimen_m.F90 | Updated specimen module: changed zero() to return a real value and added one() |
| demo/include/language-support.F90 | New file for compiler-dependent configuration |
| demo/fpm.toml | New FPM manifest file with dependency specification |
| demo/README.md | Updated documentation to reflect the new test suite structure |
| README.md | Updated global README to refer to the demonstration test suite |
Contributor
Author
|
@ktras this PR is ready for review. |
Contributor
Author
|
@ktras I let Co-Pilot do a review. It caught a few typos and made suggestions that I have accepted. :) |
rouson
force-pushed
the
revise-example-test-suite
branch
from
bbd4059 to
9e746c7
Compare
This commit 1. Moves/renames example/example-test-suite to demo/, 2. Adds fpm.toml to demo/, sets up an fpm-inspired directory tree, 3. Updates & expands specimen_test_m to leverage Julienne operators, 4. Updates the root-directory README.md accordingly, 5. Deprecates vector_* types as redundant with operator(.all.), and 6. Adds example/README.md redirectoring readers to ../demo except for the string-handling examples.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rouson
force-pushed
the
revise-example-test-suite
branch
from
9e746c7 to
6539c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
example/example-test-suitetodemo/,demo/fpm.tomland sets up an fpm-inspired directory tree:demo/src,demo/test,demo/test/specimen_test_mto leverage Julienne operators,README.mdaccordingly,vector_*types as redundant withoperator(.all.), andexample/README.mdredirecting readers to../demoexcept for the string-handling examples.To Do
gfortranissue below.\