For JWT signature authorization. changed EXPECTED_ISS and removed rescue block

Author: davezuckerman

app/controllers/concerns/alma_jwt_validator.rb

@@ -4,7 +4,7 @@
 
 module AlmaJwtValidator
   JWKS_URL = 'https://api-na.hosted.exlibrisgroup.com/auth/01UCS_BER/jwks.json'.freeze
-  EXPECTED_ISS = 'https://api-na.hosted.exlibrisgroup.com/auth/01UCS_BER'.freeze
+  EXPECTED_ISS = 'Prima'.freeze
 
   module_function
 
@@ -16,7 +16,6 @@ def jwk_set
     end
   end
 
-  # rubocop:disable Metrics/MethodLength
   def decode_and_verify_jwt(token)
     options = {
       algorithm: 'RS256',
@@ -28,8 +27,5 @@ def decode_and_verify_jwt(token)
     }
 
     JWT.decode(token, nil, true, options)
-  rescue JWT::DecodeError => e
-    raise JWT::VerificationError, e.message
   end
-  # rubocop:enable Metrics/MethodLength
 end

spec/controllers/concerns/alma_jwt_validator_spec.rb

@@ -6,7 +6,7 @@
 describe AlmaJwtValidator do
   let(:alma_institution_code) { '01UCS_BER' }
   let(:jwks_url) { "https://api-na.hosted.exlibrisgroup.com/auth/#{alma_institution_code}/jwks.json" }
-  let(:expected_iss) { "https://api-na.hosted.exlibrisgroup.com/auth/#{alma_institution_code}" }
+  let(:expected_iss) { 'Prima' }
 
   # Generate an RSA key pair for testing
   let(:rsa_key) { OpenSSL::PKey::RSA.new(2048) }
@@ -49,32 +49,32 @@ def generate_jwt(payload, key, kid, algorithm = 'RS256')
     end
 
     context 'with an invalid signature' do
-      it 'raises JWT::VerificationError' do
+      it 'raises JWT::DecodeError' do
         # Generate a token with a different key
         different_key = OpenSSL::PKey::RSA.new(2048)
         token = generate_jwt(test_payload, different_key, kid)
 
         expect do
           AlmaJwtValidator.decode_and_verify_jwt(token)
-        end.to raise_error(JWT::VerificationError)
+        end.to raise_error(JWT::DecodeError)
       end
     end
 
     context 'with an unknown key id' do
-      it 'raises JWT::VerificationError' do
+      it 'raises JWT::DecodeError' do
         token = generate_jwt(test_payload, rsa_key, 'unknown-kid')
 
         expect do
           AlmaJwtValidator.decode_and_verify_jwt(token)
-        end.to raise_error(JWT::VerificationError)
+        end.to raise_error(JWT::DecodeError)
       end
     end
 
     context 'with a malformed JWT' do
-      it 'raises JWT::VerificationError' do
+      it 'raises JWT::DecodeError' do
         expect do
           AlmaJwtValidator.decode_and_verify_jwt('not.a.jwt')
-        end.to raise_error(JWT::VerificationError)
+        end.to raise_error(JWT::DecodeError)
       end
     end