Changing doemoff_patron_email_form to use struct similar to affiliate_borrower

Author: David Zuckerman

app/mailers/request_mailer.rb

@@ -40,11 +40,15 @@ def doemoff_room_failure_email(empid, displayname, note)
     mail(to: admin_to)
   end
 
-  # Sends doemoff patron email
-  def doemoff_patron_email(email_form)
-    @email_form = email_form
-    mail(to: @email_form.patron_email, bcc: @email_form.recipient_email, reply_to: @email_form.recipient_email,
-         subject: 'Message from Doe/Moffitt Libraries Staff')
+  def doemoff_patron_email(payload)
+    @email_form = DoemoffPatronEmailForm::PatronEmail.new(**payload)
+
+    mail(
+      to: @email_form.patron_email,
+      bcc: @email_form.recipient_email,
+      reply_to: @email_form.recipient_email,
+      subject: 'Message from Doe/Moffitt Libraries Staff'
+    )
   end
 
   # Sends the Security Incident form email

app/models/doemoff_patron_email_form.rb

@@ -1,20 +1,28 @@
 class DoemoffPatronEmailForm < Form
-  attr_accessor(
-    :patron_email,
-    :patron_message,
-    :sender,
-    :recipient_email
-  )
+  ATTRIBUTES = %i[
+    patron_email
+    patron_message
+    sender
+    recipient_email
+  ].freeze
+
+  PatronEmail = Struct.new(*ATTRIBUTES, keyword_init: true)
+
+  attr_accessor(*ATTRIBUTES)
 
   validates :patron_email,
             email: true,
             presence: true
 
   validates :patron_message, :sender, :recipient_email, presence: true
 
-  private
+  def to_h
+    ATTRIBUTES.index_with { |attr| public_send(attr) }
+  end
+
+  def submit!
+    raise ActiveModel::ValidationError, self unless valid?
 
-  def submit
-    RequestMailer.doemoff_patron_email(:patron_email, :patron_message, :sender, :recipient_email).deliver_later
+    RequestMailer.doemoff_patron_email(to_h).deliver_later
   end
 end