Add rspec tests for endpoint http head checks

Author: yzhoubk

lib/endpoint_url.rb

@@ -2,12 +2,12 @@ class EndpointUrl
   class << self
     def geoserver(server_name)
       url = Rails.configuration.x.servers[server_name]
-      url && "#{url.chomp('/')}/wms?service=WMS&request=GetCapabilities"
+      url && "#{url.sub(%r{/+\z}, '')}/wms?service=WMS&request=GetCapabilities"
     end
 
     def spatial_server(server_name)
       url = Rails.configuration.x.servers[server_name]
-      url && "#{url.chomp('/')}/public/berkeley-status/data.zip"
+      url && "#{url.sub(%r{/+\z}, '')}/public/berkeley-status/data.zip"
     end
   end
 end

spec/lib/endpoint_url_spec.rb

@@ -0,0 +1,53 @@
+require 'rails_helper'
+
+describe EndpointUrl do
+  describe '.geoserver' do
+    context 'when server is configured' do
+      before do
+        allow(Rails.configuration.x.servers).to receive(:[]).with('test_server').and_return('https://example.com//')
+      end
+
+      it 'returns WMS endpoint URL' do
+        result = EndpointUrl.geoserver('test_server')
+        expect(result).to eq('https://example.com/wms?service=WMS&request=GetCapabilities')
+      end
+
+    end
+
+    context 'when server is not configured' do
+      before do
+        allow(Rails.configuration.x.servers).to receive(:[]).with('missing_server').and_return(nil)
+      end
+
+      it 'returns nil' do
+        result = EndpointUrl.geoserver('missing_server')
+        expect(result).to be_nil
+      end
+    end
+  end
+
+  describe '.spatial_server' do
+    context 'when server is configured' do
+      before do
+        allow(Rails.configuration.x.servers).to receive(:[]).with('test_server').and_return('https://example.com//')
+      end
+
+      it 'returns spatial server data zip endpoint URL' do
+        result = EndpointUrl.spatial_server('test_server')
+        expect(result).to eq('https://example.com/public/berkeley-status/data.zip')
+      end
+
+    end
+
+    context 'when server is not configured' do
+      before do
+        allow(Rails.configuration.x.servers).to receive(:[]).with('missing_server').and_return(nil)
+      end
+
+      it 'returns nil' do
+        result = EndpointUrl.spatial_server('missing_server')
+        expect(result).to be_nil
+      end
+    end
+  end
+end

spec/lib/http_head_check_spec.rb

@@ -0,0 +1,81 @@
+require 'spec_helper'
+require_relative '../../lib/http_head_check'
+
+RSpec.describe GeoDataHealthCheck::HttpHeadCheck do
+  let(:test_url) { URI('http://example.com/endpoint') }
+  let(:check) { described_class.new(test_url) }
+
+  describe '#check' do
+    it 'succeeds when response is 200 OK' do
+      response = Net::HTTPOK.new('1.1', '200', 'OK')
+      allow(check).to receive(:perform_request).and_return(response)
+
+      check.check
+
+      expect(check.message).to include('Http head check successful.')
+    end
+
+    it 'succeeds when response is a redirect' do
+      response = Net::HTTPFound.new('1.1', '302', 'Found')
+      allow(check).to receive(:perform_request).and_return(response)
+
+      check.check
+
+      expect(check.message).to include('Http head check successful.')
+    end
+
+    it 'fails when response is 404' do
+      response = Net::HTTPNotFound.new('1.1', '404', 'Not Found')
+      allow(check).to receive(:perform_request).and_return(response)
+
+      check.check
+
+      expect(check.message).to include('http head check responded, but returned unexpeced HTTP status: 404 Net::HTTPNotFound')
+    end
+
+    it 'fails when request raises an error' do
+      error = StandardError.new('Connection error')
+      allow(check).to receive(:perform_request).and_raise(error)
+
+      check.check
+
+      expect(check.message).to include('Error:')
+      expect(check.message).to include('Connection error')
+    end
+  end
+
+  describe '#perform_request' do
+    it 'calls head_request' do
+      response = Net::HTTPOK.new('1.1', '200', 'OK')
+      allow(check).to receive(:head_request).and_return(response)
+
+      result = check.perform_request
+
+      expect(result).to eq response
+    end
+
+    it 'raises ConnectionFailed on OpenTimeout' do
+      allow(check).to receive(:head_request).and_raise(Net::OpenTimeout.new)
+
+      expect do
+        check.perform_request
+      end.to raise_error(OkComputer::HttpCheck::ConnectionFailed)
+    end
+
+    it 'raises ConnectionFailed on ReadTimeout' do
+      allow(check).to receive(:head_request).and_raise(Net::ReadTimeout.new)
+
+      expect do
+        check.perform_request
+      end.to raise_error(OkComputer::HttpCheck::ConnectionFailed)
+    end
+
+    it 'raises ConnectionFailed on StandardError' do
+      allow(check).to receive(:head_request).and_raise(StandardError.new)
+
+      expect do
+        check.perform_request
+      end.to raise_error(OkComputer::HttpCheck::ConnectionFailed)
+    end
+  end
+end