AP 475 SLF Changes#5
Merged
Merged
Conversation
anarchivist
previously approved these changes
Jan 10, 2026
| with: | ||
| name: artifacts | ||
| path: artifacts/** | ||
| overwrite: true |
Member
There was a problem hiding this comment.
why are we overwriting artifacts? does this have something to do with the ruby version build matrix?
Contributor
Author
There was a problem hiding this comment.
I was going to ask about that on Monday - I was getting an error that artifacts already existed and it couldn't write to the same space (or something along those lines). Other option, I could set the names to be unique per job.
Contributor
Author
There was a problem hiding this comment.
I think something like this would work:
with:
name: artifacts-${{ matrix.os }}-${{ matrix.ruby }}
path: artifacts/**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename RLF to SLF (as well as NRLF to SLFN, SRLF to SLFS)