Ap 725 upload dir#86
Conversation
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Looking good overall, but a few things we can improve.
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
Some additional comments beyond @awilfox's.
steve-sullivan
left a comment
steve-sullivan
left a comment
There was a problem hiding this comment.
Looks good to me - I just question that one log line, but not that big of a deal.
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
a few more minor changes.
| ) | ||
|
|
||
| # This should be last in the chain | ||
| chain(renamed_temp_dir, check_lpsdata, moved_lpsdata_to_uploaded) |
There was a problem hiding this comment.
| chain(renamed_temp_dir, check_lpsdata, moved_lpsdata_to_uploaded) | |
| chain(renamed_temp_dir, [check_lpsdata, moved_lpsdata_to_uploaded]) |
There was a problem hiding this comment.
When I pass it in that way (as a list) for some reason it always calls moved_lpsdata_to_upload even if check_lpsdata returns false. When it's passed it as it is currently it has the expected behavior. I think passing it in as a list makes it run in parrallel.
awilfox
left a comment
awilfox
left a comment
There was a problem hiding this comment.
Overall looks good, a few minor nits.
…digits it will simply create an Uploaded directory
anarchivist
left a comment
anarchivist
left a comment
There was a problem hiding this comment.
one more comment; sorry for the back and forth on this.
…digits will create an Uploaded directory as a subdirectory to the source directory
4 participants
No description provided.