Replace lambda expressions with method references (#304)

* Replace lambda expressions with method references in test files

Replaced () -> builder.build() with builder::build in 36 occurrences across 10 test files to improve code readability and align with Java best practices.

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>

* Replace lambda expressions with method references in sample applications

Replaced forEach(s -> System.out.println(s)) and forEach(id -> System.out.println(id)) with forEach(System.out::println) in 9 occurrences across 6 sample application files.

Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>

Author: Copilot

samples/get-activity-profiles/src/main/java/dev/learning/xapi/samples/getactivityprofiles/GetActivityProfilesApplication.java

@@ -45,7 +45,7 @@ public void run(String... args) throws Exception {
             .block();
 
     // Print the each returned activity profile id to the console
-    response.getBody().stream().forEach(id -> System.out.println(id));
+    response.getBody().stream().forEach(System.out::println);
   }
 
   private void postActivityProfile() {

samples/get-agent-profiles/src/main/java/dev/learning/xapi/samples/getagentprofiles/GetAgentProfilesApplication.java

@@ -40,7 +40,7 @@ public void run(String... args) throws Exception {
         .block();
 
     // Print the each returned profile id to the console
-    response.getBody().stream().forEach(id -> System.out.println(id));
+    response.getBody().stream().forEach(System.out::println);
 
   }
 

samples/get-more-statements/src/main/java/dev/learning/xapi/samples/getmorestatements/GetMoreStatementsApplication.java

@@ -40,15 +40,15 @@ public void run(String... args) throws Exception {
     StatementResult result = response.getBody();
 
     // Print the returned statements to the console
-    Arrays.asList(result.getStatements()).forEach(s -> System.out.println(s));
+    Arrays.asList(result.getStatements()).forEach(System.out::println);
 
     if (result.hasMore()) {
       // Get More Statements
       ResponseEntity<StatementResult> more =
           client.getMoreStatements(r -> r.more(result.getMore())).block();
 
       // Print the returned statements to the console
-      Arrays.asList(more.getBody().getStatements()).forEach(s -> System.out.println(s));
+      Arrays.asList(more.getBody().getStatements()).forEach(System.out::println);
     }
   }
 

samples/get-statement-iterator/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementIteratorApplication.java

@@ -37,14 +37,14 @@ public void run(String... args) throws Exception {
     var statements = client.getStatementIterator().block();
 
     // Print the returned statements to the console
-    statements.toStream().forEach(s -> System.out.println(s));
+    statements.toStream().forEach(System.out::println);
 
     // Get Statements with Verb filter as StatementIterator
     var filteredStatements =
         client.getStatementIterator(r -> r.verb(Verb.ATTEMPTED)).block();
 
     // Print the returned statements to the console
-    filteredStatements.toStream().forEach(s -> System.out.println(s));
+    filteredStatements.toStream().forEach(System.out::println);
 
   }
 

samples/get-statements/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementsApplication.java

@@ -38,7 +38,7 @@ public void run(String... args) throws Exception {
     ResponseEntity<StatementResult> response = client.getStatements().block();
 
     // Print the returned statements to the console
-    response.getBody().getStatements().forEach(s -> System.out.println(s));
+    response.getBody().getStatements().forEach(System.out::println);
 
 
 
@@ -47,7 +47,7 @@ public void run(String... args) throws Exception {
         client.getStatements(r -> r.verb(Verb.ATTEMPTED.getId())).block();
 
     // Print the returned statements to the console
-    filteredResponse.getBody().getStatements().forEach(s -> System.out.println(s));
+    filteredResponse.getBody().getStatements().forEach(System.out::println);
 
   }
 

samples/get-states/src/main/java/dev/learning/xapi/samples/getstates/GetStatesApplication.java

@@ -49,7 +49,7 @@ public void run(String... args) throws Exception {
         .block();
 
     // Print the each returned state id to the console
-    response.getBody().stream().forEach(id -> System.out.println(id));
+    response.getBody().stream().forEach(System.out::println);
 
   }
 

xapi-client/src/test/java/dev/learning/xapi/client/DeleteActivityProfileRequestTests.java

@@ -35,7 +35,7 @@ void whenBuildingDeleteActivityProfileRequestWithAllParametersThenNoExceptionIsT
         .profileId("bookmark");
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -50,7 +50,7 @@ void whenBuildingDeleteActivityProfileRequestWithoutRegistrationThenNoExceptionI
         .profileId("bookmark");
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -63,7 +63,7 @@ void whenBuildingDeleteActivityProfileRequestWithoutActivityIdThenExceptionIsThr
         .profileId("bookmark");
 
     // Then NullPointerException Is Thrown
-    assertThrows(NullPointerException.class, () -> builder.build());
+    assertThrows(NullPointerException.class, builder::build);
 
   }
 
@@ -76,7 +76,7 @@ void whenBuildingDeleteActivityProfileRequestWithoutStateIdThenExceptionIsThrown
         .activityId(URI.create("https://example.com/activity/1"));
 
     // Then NullPointerException Is Thrown
-    assertThrows(NullPointerException.class, () -> builder.build());
+    assertThrows(NullPointerException.class, builder::build);
 
   }
 

xapi-client/src/test/java/dev/learning/xapi/client/DeleteStateRequestTests.java

@@ -39,7 +39,7 @@ void whenBuildingDeleteStateRequestWithAllParametersThenNoExceptionIsThrown() {
         .stateId("bookmark");
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -56,7 +56,7 @@ void whenBuildingDeleteStateRequestWithoutRegistrationThenNoExceptionIsThrown()
         .stateId("bookmark");
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -73,7 +73,7 @@ void whenBuildingDeleteStateRequestWithoutActivityIdThenExceptionIsThrown() {
         .stateId("bookmark");
 
     // Then NullPointerException Is Thrown
-    assertThrows(NullPointerException.class, () -> builder.build());
+    assertThrows(NullPointerException.class, builder::build);
 
   }
 
@@ -90,7 +90,7 @@ void whenBuildingDeleteStateRequestWithoutAgentThenExceptionIsThrown() {
         .stateId("bookmark");
 
     // Then NullPointerException Is Thrown
-    assertThrows(NullPointerException.class, () -> builder.build());
+    assertThrows(NullPointerException.class, builder::build);
 
   }
 
@@ -107,7 +107,7 @@ void whenBuildingDeleteStateRequestWithoutStateIdThenExceptionIsThrown() {
         .registration("67828e3a-d116-4e18-8af3-2d2c59e27be6");
 
     // Then NullPointerException Is Thrown
-    assertThrows(NullPointerException.class, () -> builder.build());
+    assertThrows(NullPointerException.class, builder::build);
 
   }
 

xapi-client/src/test/java/dev/learning/xapi/client/DeleteStatesRequestTests.java

@@ -38,7 +38,7 @@ void whenBuildingDeleteStatesRequestWithAllParametersThenNoExceptionIsThrown() {
         .registration("67828e3a-d116-4e18-8af3-2d2c59e27be6");
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -55,7 +55,7 @@ void whenBuildingDeleteStatesRequestWithRegistrationAsUUIDTypeThenNoExceptionIsT
         .registration(UUID.fromString("67828e3a-d116-4e18-8af3-2d2c59e27be6"));
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -72,7 +72,7 @@ void whenBuildingDeleteStatesRequestWithActivityIdAsURITypeThenNoExceptionIsThro
         .registration("67828e3a-d116-4e18-8af3-2d2c59e27be6");
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -87,7 +87,7 @@ void whenBuildingDeleteStatesRequestWithoutRegistrationThenNoExceptionIsThrown()
         .agent(a -> a.name("A N Other").mbox("mailto:another@example.com"));
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -102,7 +102,7 @@ void whenBuildingDeleteStatesRequestWithoutActivityIdThenExceptionIsThrown() {
         .registration("67828e3a-d116-4e18-8af3-2d2c59e27be6");
 
     // Then NullPointerException Is Thrown
-    assertThrows(NullPointerException.class, () -> builder.build());
+    assertThrows(NullPointerException.class, builder::build);
 
   }
 
@@ -117,7 +117,7 @@ void whenBuildingDeleteStatesRequestWithoutAgentThenExceptionIsThrown() {
         .registration("67828e3a-d116-4e18-8af3-2d2c59e27be6");
 
     // Then NullPointerException Is Thrown
-    assertThrows(NullPointerException.class, () -> builder.build());
+    assertThrows(NullPointerException.class, builder::build);
 
   }
 

xapi-client/src/test/java/dev/learning/xapi/client/GetActivityProfilesRequestTests.java

@@ -36,7 +36,7 @@ void whenBuildingGetActivityProfilesRequestWithAllParametersThenNoExceptionIsThr
         .since(Instant.parse("2016-01-01T00:00:00Z"));
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -49,7 +49,7 @@ void whenBuildingGetActivityProfilesRequestWithActivityIdAsURITypeThenNoExceptio
         .activityId(URI.create("https://example.com/activity/1"));
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -62,7 +62,7 @@ void whenBuildingGetActivityProfilesRequestWithoutRegistrationThenNoExceptionIsT
         .activityId("https://example.com/activity/1");
 
     // Then No Exception Is Thrown
-    assertDoesNotThrow(() -> builder.build());
+    assertDoesNotThrow(builder::build);
 
   }
 
@@ -73,7 +73,7 @@ void whenBuildingGetActivityProfilesRequestWithoutActivityIdThenExceptionIsThrow
     Builder builder = GetActivityProfilesRequest.builder();
 
     // Then NullPointerException Is Thrown
-    assertThrows(NullPointerException.class, () -> builder.build());
+    assertThrows(NullPointerException.class, builder::build);
 
   }