Update maven workflows to use maven wrapper and add javadoc validation (#385)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thomasturrell <1552612+thomasturrell@users.noreply.github.com>

Author: Copilot

.github/workflows/maven-publish-snapshot.yml

@@ -19,12 +19,14 @@ jobs:
           distribution: "temurin"
           cache: maven
       - name: Build with Maven
-        run: mvn -B verify --file pom.xml
+        run: ./mvnw -B install
+      - name: Check documentation
+        run: ./mvnw -B javadoc:javadoc -pl xapi-model,xapi-client,xapi-model-spring-boot-starter -am # This checks that the Javadoc is valid
       - name: Scan with Sonar
         run: |
           if [ $FORK = false ] && [ "$ACTOR" != "dependabot[bot]" ]
           then
-            mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BerryCloud_xapi-java -Dsonar.organization=berrycloud --file pom.xml
+            ./mvnw org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BerryCloud_xapi-java -Dsonar.organization=berrycloud
           fi
         env:
           FORK: ${{ github.event.pull_request.head.repo.fork }}

.github/workflows/maven-publish.yml

@@ -19,9 +19,9 @@ jobs:
           distribution: "temurin"
           cache: maven
       - name: Build with Maven
-        run: mvn -B verify --file pom.xml
+        run: ./mvnw -B verify
       - name: Scan with Sonar
-        run: mvn org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BerryCloud_xapi-java -Dsonar.organization=berrycloud --file pom.xml
+        run: ./mvnw org.sonarsource.scanner.maven:sonar-maven-plugin:sonar -Dsonar.projectKey=BerryCloud_xapi-java -Dsonar.organization=berrycloud
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}