Remove unthrown exception declarations from methods (#309)

Copilot · thomasturrell · web-flow · commit 84135d526ae5 · 2025-11-13T07:49:58.000Z
* Remove unnecessary throws Exception declarations from sample applications

Co-authored-by: thomasturrell &lt;1552612+thomasturrell@users.noreply.github.com&gt;

* Remove unnecessary throws InterruptedException from test methods

Co-authored-by: thomasturrell &lt;1552612+thomasturrell@users.noreply.github.com&gt;

* Remove additional unnecessary exception declarations from test methods

Co-authored-by: thomasturrell &lt;1552612+thomasturrell@users.noreply.github.com&gt;

* Remove unused JsonMappingException import from StatementTests

Co-authored-by: thomasturrell &lt;1552612+thomasturrell@users.noreply.github.com&gt;

---------

Co-authored-by: copilot-swe-agent[bot] &lt;198982749+Copilot@users.noreply.github.com&gt;
Co-authored-by: thomasturrell &lt;1552612+thomasturrell@users.noreply.github.com&gt;
diff --git a/samples/delete-activity-profile/src/main/java/dev/learning/xapi/samples/deleteactivityprofile/DeleteActivityProfileApplication.java b/samples/delete-activity-profile/src/main/java/dev/learning/xapi/samples/deleteactivityprofile/DeleteActivityProfileApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post activity profile for later deletion
     postActivityProfile();
diff --git a/samples/delete-agent-profile/src/main/java/dev/learning/xapi/samples/deleteagentprofile/DeleteAgentProfileApplication.java b/samples/delete-agent-profile/src/main/java/dev/learning/xapi/samples/deleteagentprofile/DeleteAgentProfileApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post Example agent profile for later deletion
     postAgentProfile();
diff --git a/samples/delete-state/src/main/java/dev/learning/xapi/samples/deletestate/DeleteStateApplication.java b/samples/delete-state/src/main/java/dev/learning/xapi/samples/deletestate/DeleteStateApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post Example state for later deletion
     postState();
diff --git a/samples/delete-states/src/main/java/dev/learning/xapi/samples/deletestates/DeleteStatesApplication.java b/samples/delete-states/src/main/java/dev/learning/xapi/samples/deletestates/DeleteStatesApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post state for later deletion
     postState();
diff --git a/samples/get-about/src/main/java/dev/learning/xapi/samples/getabout/GetAboutApplication.java b/samples/get-about/src/main/java/dev/learning/xapi/samples/getabout/GetAboutApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Get About
     ResponseEntity<About> response = client.getAbout().block();
diff --git a/samples/get-activity-profile/src/main/java/dev/learning/xapi/samples/getactivityprofile/GetActivityProfileApplication.java b/samples/get-activity-profile/src/main/java/dev/learning/xapi/samples/getactivityprofile/GetActivityProfileApplication.java
@@ -32,7 +32,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post activity profile for later retrieval
     postActivityProfile();
diff --git a/samples/get-activity-profiles/src/main/java/dev/learning/xapi/samples/getactivityprofiles/GetActivityProfilesApplication.java b/samples/get-activity-profiles/src/main/java/dev/learning/xapi/samples/getactivityprofiles/GetActivityProfilesApplication.java
@@ -33,7 +33,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post Example Activity profile for later retrieval
     postActivityProfile();
diff --git a/samples/get-activity/src/main/java/dev/learning/xapi/samples/getactivity/GetActivityApplication.java b/samples/get-activity/src/main/java/dev/learning/xapi/samples/getactivity/GetActivityApplication.java
@@ -35,7 +35,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post statement for later retrieval of activity
     postStatement();
diff --git a/samples/get-agent-profile/src/main/java/dev/learning/xapi/samples/getagentprofile/GetAgentProfileApplication.java b/samples/get-agent-profile/src/main/java/dev/learning/xapi/samples/getagentprofile/GetAgentProfileApplication.java
@@ -32,7 +32,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post Example profile for later retrieval
     postAgentProfile();
diff --git a/samples/get-agent-profiles/src/main/java/dev/learning/xapi/samples/getagentprofiles/GetAgentProfilesApplication.java b/samples/get-agent-profiles/src/main/java/dev/learning/xapi/samples/getagentprofiles/GetAgentProfilesApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Get Profiles
     ResponseEntity<List<String>> response = client
diff --git a/samples/get-agents/src/main/java/dev/learning/xapi/samples/getagents/GetAgentsApplication.java b/samples/get-agents/src/main/java/dev/learning/xapi/samples/getagents/GetAgentsApplication.java
@@ -34,7 +34,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post statement for later retrieval of Agent
     postStatement();
diff --git a/samples/get-more-statements/src/main/java/dev/learning/xapi/samples/getmorestatements/GetMoreStatementsApplication.java b/samples/get-more-statements/src/main/java/dev/learning/xapi/samples/getmorestatements/GetMoreStatementsApplication.java
@@ -32,7 +32,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Get Statements
     ResponseEntity<StatementResult> response = client.getStatements(r -> r.limit(1)).block();
diff --git a/samples/get-state/src/main/java/dev/learning/xapi/samples/getstate/GetStateApplication.java b/samples/get-state/src/main/java/dev/learning/xapi/samples/getstate/GetStateApplication.java
@@ -32,7 +32,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post Example state for later retrieval
     postState();
diff --git a/samples/get-statement-iterator/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementIteratorApplication.java b/samples/get-statement-iterator/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementIteratorApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Get Statements as StatementIterator
     var statements = client.getStatementIterator().block();
diff --git a/samples/get-statement/src/main/java/dev/learning/xapi/samples/getstatement/GetStatementApplication.java b/samples/get-statement/src/main/java/dev/learning/xapi/samples/getstatement/GetStatementApplication.java
@@ -34,7 +34,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Get Statements
     ResponseEntity<Statement> response = client.getStatement(r -> r.id(postStatement())).block();
diff --git a/samples/get-statements/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementsApplication.java b/samples/get-statements/src/main/java/dev/learning/xapi/samples/getstatements/GetStatementsApplication.java
@@ -32,7 +32,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Get Statements
     ResponseEntity<StatementResult> response = client.getStatements().block();
diff --git a/samples/get-states/src/main/java/dev/learning/xapi/samples/getstates/GetStatesApplication.java b/samples/get-states/src/main/java/dev/learning/xapi/samples/getstates/GetStatesApplication.java
@@ -33,7 +33,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post Example state for later retrieval
     postState();
diff --git a/samples/get-voided-statement/src/main/java/dev/learning/xapi/samples/getvoidedstatement/GetVoidedStatementApplication.java b/samples/get-voided-statement/src/main/java/dev/learning/xapi/samples/getvoidedstatement/GetVoidedStatementApplication.java
@@ -34,7 +34,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Get Voided Statement
     ResponseEntity<Statement> response =
diff --git a/samples/post-activity-profile/src/main/java/dev/learning/xapi/samples/postactivityprofile/PostActivityProfileApplication.java b/samples/post-activity-profile/src/main/java/dev/learning/xapi/samples/postactivityprofile/PostActivityProfileApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post activity profile
     client.postActivityProfile(r -> r
diff --git a/samples/post-agent-profile/src/main/java/dev/learning/xapi/samples/postagentprofile/PostAgentProfileApplication.java b/samples/post-agent-profile/src/main/java/dev/learning/xapi/samples/postagentprofile/PostAgentProfileApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post Profile
     client
diff --git a/samples/post-state/src/main/java/dev/learning/xapi/samples/poststate/PostStateApplication.java b/samples/post-state/src/main/java/dev/learning/xapi/samples/poststate/PostStateApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post State
     client.postState(r -> r.activityId("https://example.com/activity/1")
diff --git a/samples/post-statement/src/main/java/dev/learning/xapi/samples/poststatement/PostStatementApplication.java b/samples/post-statement/src/main/java/dev/learning/xapi/samples/poststatement/PostStatementApplication.java
@@ -33,7 +33,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Post a statement
     ResponseEntity<
diff --git a/samples/post-statements/src/main/java/dev/learning/xapi/samples/poststatements/PostStatementsApplication.java b/samples/post-statements/src/main/java/dev/learning/xapi/samples/poststatements/PostStatementsApplication.java
@@ -32,7 +32,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     Statement attemptedStatement = Statement.builder()
         .agentActor(a -> a.name("A N Other").mbox("mailto:another@example.com"))
diff --git a/samples/put-activity-profile/src/main/java/dev/learning/xapi/samples/putactivityprofile/PutActivityProfileApplication.java b/samples/put-activity-profile/src/main/java/dev/learning/xapi/samples/putactivityprofile/PutActivityProfileApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Put activity profile
     client.putActivityProfile(r -> r
diff --git a/samples/put-agent-profile/src/main/java/dev/learning/xapi/samples/putagentprofile/PutAgentProfileApplication.java b/samples/put-agent-profile/src/main/java/dev/learning/xapi/samples/putagentprofile/PutAgentProfileApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Put Profile
     client.putAgentProfile(r -> r.agent(a -> a.name("A N Other").mbox("mailto:another@example.com"))
diff --git a/samples/put-state/src/main/java/dev/learning/xapi/samples/putstate/PutStateApplication.java b/samples/put-state/src/main/java/dev/learning/xapi/samples/putstate/PutStateApplication.java
@@ -31,7 +31,7 @@ public static void main(String[] args) {
   }
 
   @Override
-  public void run(String... args) throws Exception {
+  public void run(String... args) {
 
     // Put State
     client.putState(r -> r.activityId("https://example.com/activity/1")
diff --git a/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientMultipartTests.java b/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientMultipartTests.java
@@ -328,7 +328,7 @@ void whenPostingStatementsWithTimestampAndAttachmentThenNoExceptionIsThrown()
 
   @SuppressWarnings("null")
   @Test
-  void whenGettingStatementWithAttachmentThenResponseIsExpected() throws InterruptedException {
+  void whenGettingStatementWithAttachmentThenResponseIsExpected() {
 
     // single statement with two attachments
     final var body =
@@ -370,7 +370,7 @@ void whenGettingStatementWithAttachmentThenResponseIsExpected() throws Interrupt
 
   @SuppressWarnings("null")
   @Test
-  void whenGettingStatementsWithAttachmentsThenResponseIsExpected() throws InterruptedException {
+  void whenGettingStatementsWithAttachmentsThenResponseIsExpected() {
 
     // two statements with overlapping attachments
     final var body =
diff --git a/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientTests.java b/xapi-client/src/test/java/dev/learning/xapi/client/XapiClientTests.java
@@ -102,7 +102,7 @@ void whenGettingStatementThenPathIsExpected() throws InterruptedException {
   }
 
   @Test
-  void whenGettingStatementThenBodyIsInstanceOfStatement() throws InterruptedException {
+  void whenGettingStatementThenBodyIsInstanceOfStatement() {
 
     mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK")
 
@@ -1847,7 +1847,7 @@ void whenGettingActivityThenPathIsExpected() throws InterruptedException {
   }
 
   @Test
-  void whenGettingActivityThenBodyIsInstanceOfActivity() throws InterruptedException {
+  void whenGettingActivityThenBodyIsInstanceOfActivity() {
 
     mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK")
 
@@ -1896,7 +1896,7 @@ void whenGettingAgentsThenPathIsExpected() throws InterruptedException {
   }
 
   @Test
-  void whenGettingAgentsThenBodyIsInstanceOfPerson() throws InterruptedException {
+  void whenGettingAgentsThenBodyIsInstanceOfPerson() {
 
     mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK")
 
@@ -1951,7 +1951,7 @@ void whenGettingAboutThenPathIsExpected() throws InterruptedException {
   }
 
   @Test
-  void whenGettingAboutThenBodyIsInstanceOfAbout() throws InterruptedException {
+  void whenGettingAboutThenBodyIsInstanceOfAbout() {
 
     mockWebServer.enqueue(new MockResponse().setStatus("HTTP/1.1 200 OK")
 
diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/ActivityTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/ActivityTests.java
@@ -160,7 +160,7 @@ void whenActivityIsBuiltWithStringIdThenIdIsExpected() {
   }
 
   @Test
-  void whenDeserializingActivityWithInvalidDisplayThenResultIsExpected() throws Exception {
+  void whenDeserializingActivityWithInvalidDisplayThenResultIsExpected() {
 
     final var json =
         "{\"objectType\":\"Activity\",\"id\":\"https://example.com/activity/simplestatement\",\"definition\":{\"name\":{\"a12345678\":\"Simple Statement\"}}}";
diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/LanguageMapTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/LanguageMapTests.java
@@ -25,8 +25,7 @@ class LanguageMapTests {
 
   @ParameterizedTest
   @CsvSource({"en-GB, Colour", "en-US, Color", "de, Colour"})
-  void givenUkAndUSKeyWhenGettingLocaleValueThenValueIsExpected(String locale, String expected)
-      throws Exception {
+  void givenUkAndUSKeyWhenGettingLocaleValueThenValueIsExpected(String locale, String expected) {
 
     final var languageMap = new LanguageMap();
 
@@ -43,7 +42,7 @@ void givenUkAndUSKeyWhenGettingLocaleValueThenValueIsExpected(String locale, Str
   }
 
   @Test
-  void givenFranceGermanyandUSKeyWhenGettingUKValueThenValueIsEnglish() throws Exception {
+  void givenFranceGermanyandUSKeyWhenGettingUKValueThenValueIsEnglish() {
 
     final var languageMap = new LanguageMap();
 
@@ -61,7 +60,7 @@ void givenFranceGermanyandUSKeyWhenGettingUKValueThenValueIsEnglish() throws Exc
   }
 
   @Test
-  void givenFrenchAndEnglishKeyWhenGettingUSValueThenValueIsEnglish() throws Exception {
+  void givenFrenchAndEnglishKeyWhenGettingUSValueThenValueIsEnglish() {
 
     final var languageMap = new LanguageMap();
 
@@ -78,7 +77,7 @@ void givenFrenchAndEnglishKeyWhenGettingUSValueThenValueIsEnglish() throws Excep
   }
 
   @Test
-  void givenFrenchAndUsKeyWhenGettingCanadaFrenchValueThenValueIsFrench() throws Exception {
+  void givenFrenchAndUsKeyWhenGettingCanadaFrenchValueThenValueIsFrench() {
 
     final var languageMap = new LanguageMap();
 
@@ -95,7 +94,7 @@ void givenFrenchAndUsKeyWhenGettingCanadaFrenchValueThenValueIsFrench() throws E
   }
 
   @Test
-  void givenMapIsEmptyWhenGettingGermanValueThenValueIsNull() throws Exception {
+  void givenMapIsEmptyWhenGettingGermanValueThenValueIsNull() {
 
     final var languageMap = new LanguageMap();
 
@@ -110,7 +109,7 @@ void givenMapIsEmptyWhenGettingGermanValueThenValueIsNull() throws Exception {
   }
 
   @Test
-  void givenUsAndUndKeyWhenGettingGermanValueThenValueIsUnd() throws Exception {
+  void givenUsAndUndKeyWhenGettingGermanValueThenValueIsUnd() {
 
     final var languageMap = new LanguageMap();
 
@@ -127,8 +126,7 @@ void givenUsAndUndKeyWhenGettingGermanValueThenValueIsUnd() throws Exception {
   }
 
   @Test
-  void givenUkAndUsKeyInMapUsedToConstructLanguageMapWhenGettingUKValueThenValueIsUK()
-      throws Exception {
+  void givenUkAndUsKeyInMapUsedToConstructLanguageMapWhenGettingUKValueThenValueIsUK() {
 
     final Map<Locale, String> map = new HashMap<>();
     map.put(Locale.UK, "Colour");
diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java
diff --git a/xapi-model/src/test/java/dev/learning/xapi/model/validation/internal/validators/NotUndeterminedValidatorTests.java b/xapi-model/src/test/java/dev/learning/xapi/model/validation/internal/validators/NotUndeterminedValidatorTests.java

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public static void main(String[] args) {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`@Override`
`34`		`- public void run(String... args) throws Exception {`
	`34`	`+ public void run(String... args) {`
`35`	`35`
`36`	`36`	`// Post activity profile for later deletion`
`37`	`37`	`postActivityProfile();`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public static void main(String[] args) {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`@Override`
`35`		`- public void run(String... args) throws Exception {`
	`35`	`+ public void run(String... args) {`
`36`	`36`
`37`	`37`	`// Post activity profile for later retrieval`
`38`	`38`	`postActivityProfile();`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public static void main(String[] args) {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`@Override`
`36`		`- public void run(String... args) throws Exception {`
	`36`	`+ public void run(String... args) {`
`37`	`37`
`38`	`38`	`// Post Example Activity profile for later retrieval`
`39`	`39`	`postActivityProfile();`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public static void main(String[] args) {`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`@Override`
`38`		`- public void run(String... args) throws Exception {`
	`38`	`+ public void run(String... args) {`
`39`	`39`
`40`	`40`	`// Post statement for later retrieval of activity`
`41`	`41`	`postStatement();`