Skip to content

Commit a859c62

Browse files
committed
reverts
1 parent b8bfabb commit a859c62

13 files changed

Lines changed: 57 additions & 36 deletions

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/ActivityDefinitionValidator.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@
1313
* The {@link ActivityDefinition} being validated must be valid.
1414
*
1515
* @author István Rátkai (Selindek)
16+
*
1617
* @see <a href=
17-
* "https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#activity-definition">Activity
18-
* Definition</a>
18+
* "https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#activity-definition">Activity
19+
* Definition</a>
1920
*/
2021
public class ActivityDefinitionValidator
2122
extends DisableableValidator<ValidActivityDefinition, ActivityDefinition> {
@@ -27,12 +28,10 @@ public boolean isValidIfEnabled(ActivityDefinition value, ConstraintValidatorCon
2728
return true;
2829
}
2930

30-
return !(value.getInteractionType() == null
31-
&& (value.getCorrectResponsesPattern() != null
32-
|| value.getChoices() != null
33-
|| value.getScale() != null
34-
|| value.getSource() != null
35-
|| value.getTarget() != null
36-
|| value.getSteps() != null));
31+
return !(value.getInteractionType() == null && (value.getCorrectResponsesPattern() != null
32+
|| value.getChoices() != null || value.getScale() != null || value.getSource() != null
33+
|| value.getTarget() != null || value.getSteps() != null));
34+
3735
}
36+
3837
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/ActorValidator.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
* The {@link StatementObject} being validated must be valid.
1717
*
1818
* @author István Rátkai (Selindek)
19+
*
1920
* @see <a href="https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#actor">Actor</a>
2021
*/
2122
public class ActorValidator extends DisableableValidator<ValidActor, Object> {
@@ -29,17 +30,15 @@ public class ActorValidator extends DisableableValidator<ValidActor, Object> {
2930
public boolean isValidIfEnabled(Object value, ConstraintValidatorContext context) {
3031

3132
if (value instanceof final Group group) {
32-
return group.getAccount() == null
33-
&& group.getMbox() == null
34-
&& group.getMboxSha1sum() == null
35-
&& group.getOpenid() == null
36-
? group.getMember() != null && !group.getMember().isEmpty()
37-
: hasSingleIdentifier(group);
33+
return group.getAccount() == null && group.getMbox() == null && group.getMboxSha1sum() == null
34+
&& group.getOpenid() == null ? group.getMember() != null && !group.getMember().isEmpty()
35+
: hasSingleIdentifier(group);
3836
} else if (value instanceof final Agent agent) {
3937
return hasSingleIdentifier(agent);
4038
}
4139

4240
return true;
41+
4342
}
4443

4544
private boolean hasSingleIdentifier(Actor value) {
@@ -61,4 +60,5 @@ private boolean hasSingleIdentifier(Actor value) {
6160

6261
return n == 1;
6362
}
63+
6464
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/AuthorityValidator.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,7 @@ public boolean isValidIfEnabled(Actor value, ConstraintValidatorContext context)
3030
final var group = (Group) value;
3131
// ... or must be an anonymous Group with exactly two members
3232
return group.isAnonymous() && group.getMember().size() == 2;
33+
3334
}
35+
3436
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/HasSchemeValidatorForUri.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,7 @@ public boolean isValidIfEnabled(URI value, ConstraintValidatorContext context) {
2424
}
2525

2626
return value.getScheme() != null;
27+
2728
}
29+
2830
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/MboxValidator.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,16 @@
1414
*
1515
* @author Thomas Turrell-Croft
1616
* @author István Rátkai (Selindek)
17+
*
1718
* @see <a href="http://xmlns.com/foaf/0.1/#term_mbox">Mbox</a>
1819
*/
1920
public class MboxValidator extends DisableableValidator<Mbox, String> {
2021

2122
public static final String PREFIX = "mailto:";
2223

23-
/** Cached email validator instance to avoid repeated object creation. */
24+
/**
25+
* Cached email validator instance to avoid repeated object creation.
26+
*/
2427
private static final EmailValidator EMAIL_VALIDATOR = new EmailValidator();
2528

2629
@Override
@@ -37,4 +40,5 @@ public boolean isValidIfEnabled(String value, ConstraintValidatorContext context
3740
return value.startsWith(PREFIX)
3841
&& EMAIL_VALIDATOR.isValid(value.substring(PREFIX.length()), context);
3942
}
43+
4044
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/NotUndeterminedValidator.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,7 @@ public boolean isValidIfEnabled(Locale value, ConstraintValidatorContext context
2424
}
2525

2626
return !value.toLanguageTag().equalsIgnoreCase("und");
27+
2728
}
29+
2830
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/ScaledScoreValidator.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@
1212
* The Float being validated must be a valid scaled score.
1313
*
1414
* @author István Rátkai (Selindek)
15+
*
1516
* @see <a href="https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#details-13">xAPI Score
16-
* details</a>
17+
* details</a>
1718
*/
1819
public class ScaledScoreValidator extends DisableableValidator<ScaledScore, Float> {
1920

@@ -26,4 +27,5 @@ public boolean isValidIfEnabled(Float value, ConstraintValidatorContext context)
2627

2728
return value >= -1F && value <= 1F;
2829
}
30+
2931
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/ScoreValidator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,5 @@ public boolean isValidIfEnabled(Score value, ConstraintValidatorContext context)
2626
return (value.getMax() == null || value.getMax() >= value.getRaw())
2727
&& (value.getMin() == null || value.getMin() <= value.getRaw());
2828
}
29+
2930
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/StatementPlatformValidator.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,24 @@
1212

1313
/**
1414
* The Statement being validated must have a valid platform.
15-
*
16-
* <p>If context.platform present, then object must be an {@link Activity}.
15+
* <p>
16+
* If context.platform present, then object must be an {@link Activity}.
17+
* </p>
1718
*
1819
* @author Thomas Turrell-Croft
1920
* @author István Rátkai (Selindek)
21+
*
2022
* @see <a href="https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#requirements-10">
21-
* Statement Context Requirements</a>
23+
* Statement Context Requirements</a>
2224
*/
2325
public class StatementPlatformValidator
2426
extends DisableableValidator<ValidStatementPlatform, CoreStatement> {
2527

2628
@Override
2729
public boolean isValidIfEnabled(CoreStatement value, ConstraintValidatorContext context) {
2830

29-
return value == null
30-
|| value.getContext() == null
31-
|| value.getContext().getPlatform() == null
31+
return value == null || value.getContext() == null || value.getContext().getPlatform() == null
3232
|| value.getObject() instanceof Activity;
3333
}
34+
3435
}

xapi-model/src/main/java/dev/learning/xapi/model/validation/internal/validators/StatementRevisionValidator.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,24 @@
1212

1313
/**
1414
* The Statement being validated must have a valid revision.
15-
*
16-
* <p>If context.revision present, then object must be an {@link Activity}.
15+
* <p>
16+
* If context.revision present, then object must be an {@link Activity}.
17+
* </p>
1718
*
1819
* @author Thomas Turrell-Croft
1920
* @author István Rátkai (Selindek)
21+
*
2022
* @see <a href="https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#requirements-10">
21-
* Statement Context Requirements</a>
23+
* Statement Context Requirements</a>
2224
*/
2325
public class StatementRevisionValidator
2426
extends DisableableValidator<ValidStatementRevision, CoreStatement> {
2527

2628
@Override
2729
public boolean isValidIfEnabled(CoreStatement value, ConstraintValidatorContext context) {
2830

29-
return value == null
30-
|| value.getContext() == null
31-
|| value.getContext().getRevision() == null
31+
return value == null || value.getContext() == null || value.getContext().getRevision() == null
3232
|| value.getObject() instanceof Activity;
3333
}
34+
3435
}

0 commit comments

Comments
 (0)