Skip to content

Fix javadoc generation blocking snapshot deployment #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasturrell merged 5 commits into from
Nov 15, 2025
Merged

Fix javadoc generation blocking snapshot deployment #331

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32ac8dc
Initial plan
Copilot Nov 14, 2025
f94c176
Fix javadoc generation in maven-publish-snapshot workflow
Copilot Nov 14, 2025
cb777d8
Add javadoc validation step to maven-publish workflow
Copilot Nov 15, 2025
0edd9e7
Update .github/workflows/maven-publish.yml
thomasturrell Nov 15, 2025
af7f86d
Update .github/workflows/maven-publish.yml
thomasturrell Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven-publish-snapshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
MAVEN_USERNAME: ${{ secrets.OSSRH_USERNAME }}
MAVEN_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
- name: Generate Javadoc
run: mvn -B javadoc:javadoc --file pom.xml # This checks that the Javadoc is vaild
run: mvn -B javadoc:javadoc --file pom.xml -pl xapi-model,xapi-client,xapi-model-spring-boot-starter # This checks that the Javadoc is valid
Comment thread
thomasturrell marked this conversation as resolved.
2 changes: 2 additions & 0 deletions .github/workflows/maven-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ jobs:
server-password: MAVEN_PASSWORD
gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }}
gpg-passphrase: MAVEN_GPG_PASSPHRASE
- name: Generate Javadoc
Comment thread
thomasturrell marked this conversation as resolved.
Outdated
run: mvn -B javadoc:javadoc --file pom.xml -pl xapi-model,xapi-client,xapi-model-spring-boot-starter # This checks that the Javadoc is valid
Comment thread
thomasturrell marked this conversation as resolved.
Outdated
- name: Publish package
run: |
git config user.name "github-actions[bot]"
Expand Down
4 changes: 4 additions & 0 deletions samples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<!-- Prevent javadoc from being generated for samples -->
<skip>true</skip>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
Expand Down